Repository navigation
[mypy] Add/fix type annotations for stacks in data structures - #4362
abhinabamitra wants to merge 1 commit into
Conversation
dhruvmanila
left a comment
There was a problem hiding this comment.
Hey, @abhinabamitra thanks for doing this but there are a lot of functions in the stacks/ directory which are untyped. Our goal is to provide types for all the functions and variables (which mypy cannot infer).
You need to run a minimum of mypy . from the stacks/ directory and if possible mypy --strict ..
Also, the tests are failing so if you could take a look at why that is happening, it would be great. If you need any help, don't hesitate to ask :)
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions! |
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.