Skip to content

[mypy] Fixed type annotations in maths - #4358

Closed
dri150030 wants to merge 1 commit into
TheAlgorithms:masterfrom
dri150030:mypy-fix
Closed

dri150030 wants to merge 1 commit into
TheAlgorithms:masterfrom
dri150030:mypy-fix

Conversation

@dri150030

@dri150030 dri150030 commented Apr 25, 2021 •

Copy link
Copy Markdown

Describe your change:

For issue #4052
Improved some logic in series functions as well and I have these functions return numeric types instead of strings.
Changed permutations to combinations in triplet_sum.py since it is more appropriate for the purpose and because mypy does not recognize any fixed length tuples from permutations, but it does for combinations (See this)

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@dri150030
dri150030 requested a review from Kush1101 as a code owner April 25, 2021 23:42
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Apr 25, 2021
@dhruvmanila dhruvmanila self-assigned this Apr 27, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Apr 27, 2021
@stale

stale Bot commented Jun 3, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Used to mark an issue or pull request stale. label Jun 3, 2021
@stale

stale Bot commented Jun 16, 2021

Copy link
Copy Markdown

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

@stale stale Bot closed this Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files stale Used to mark an issue or pull request stale. tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants