Repository navigation
Fix password generator length validation - #15757
Open
dbhoopesh1-tech wants to merge 1 commit into
Open
dbhoopesh1-tech wants to merge 1 commit into
dbhoopesh1-tech wants to merge 1 commit into
Conversation
Add validation for minimum password length requirement.
Mohit-Gaur75
left a comment
There was a problem hiding this comment.
Thanks for working on this validation!
There is an IndentationError in the if block where raise ValueError is not indented 8 spaces (4 spaces deeper than if), which is why the ruff and build CI checks are failing.
Please see the suggestion below to fix the indentation. Additionally, per the repository's contributing guidelines, consider adding a doctest to demonstrate this ValueError when i < len(chars_incl).
Comment on lines
+32
to
+35
| if i < len(chars_incl): | ||
| raise ValueError( | ||
| "Password length must be at least the number of required characters" | ||
| ) |
There was a problem hiding this comment.
Suggested change
| if i < len(chars_incl): | |
| raise ValueError( | |
| "Password length must be at least the number of required characters" | |
| ) | |
| if i < len(chars_incl): | |
| raise ValueError( | |
| "Password length must be at least the number of required characters" | |
| ) |
The raise ValueError block must be indented under the if statement to avoid an IndentationError.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation for minimum password length requirement.
Describe your change
Checklist