Repository navigation
feat(graphs): implement linear-time 2-SAT solver with Kosaraju - #15746
Open
matheusrodrigues2006 wants to merge 3 commits into
Open
matheusrodrigues2006 wants to merge 3 commits into
matheusrodrigues2006 wants to merge 3 commits into
Conversation
for more information, see https://pre-commit.ci
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Summary
Add a dedicated 2-SAT solver in graphs/two_sat.py. The algorithm constructs an implication graph from a 2-CNF formula and uses iterative Kosaraju strongly connected components to determine whether a satisfying assignment exists.
For a clause (a OR b), the graph contains NOT a -> b and NOT b -> a. If any variable and its negation belong to the same strongly connected component, the formula is unsatisfiable; otherwise, the function returns a Boolean assignment.
The implementation includes:
This is different from the repository's general-purpose DPLL SAT solver: it uses the specialized polynomial-time solution available for 2-CNF.
Verification
Executed locally with Python 3.13.5:
Ruff and the full upstream CI on Python 3.15t were not executed in the local environment; those checks still need to run in GitHub Actions.
Checklist
References: