Repository navigation
Feature/588 default virtual temp folder - #590
Merged
fgreinacher merged 6 commits intoMay 6, 2020
Merged
fgreinacher merged 6 commits into
fgreinacher merged 6 commits into
Conversation
added 5 commits
May 4, 2020 16:39
fgreinacher
reviewed
May 5, 2020
fgreinacher
left a comment
fgreinacher
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR! Left some comments and will happily merge once those are addressed!
Contributor
Author
|
Thanks for the feedback and suggestions @fgreinacher ! I've pushed the changes |
Contributor
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the issue #588 I've added a default temp directory to MockFileSystem (ping @fgreinacher )
I'm not 100% sure with my solution to use the previous GetTempPath as a fallback if the path passed in to the MockPath is null or empty (or the original constructor is called).
Let me know what you think, I'm torn but decided on the fallback as not to add a breaking change.