Repository navigation
Move a readonly file results in inconsistent state #870
Description
Describe the bug
Moving a readonly file throws (correctly) an UnauthorizedAccessException, but afterwards both the source file and also the target file exist.
To Reproduce
Consider the following unit test (using Xunit and FluentAssertions):
[Fact]
public void MoveFile_WithReadOnlyAttribute_ShouldThrowExceptionAndNotMoveFile()
{
var sut = new MockFileSystem();
sut.File.WriteAllText("foo.txt", "xyz");
sut.File.SetAttributes("foo.txt", FileAttributes.ReadOnly);
var exception = Record.Exception(() =>
{
sut.File.Move("foo.txt", "bar.txt");
});
exception.Should().BeAssignableTo<UnauthorizedAccessException>();
sut.File.Exists("foo.txt").Should().BeTrue();
sut.File.Exists("bar.txt").Should().BeFalse();
}This test fails at the last line, as the file exists now twice, resulting in an inconsistent state of the MockFileSystem
Expected behavior
The unit test should be successful.
Additional context
This issue might have similar root cause as #849 ?
Activity
vbreuss commentedon Aug 9, 2022
I would be happy to provide a solution for this issue myself. Will create a pull request shortly...
fix: TestableIO#870 Moving a readonly file duplicates the file
fix: TestableIO#870 Moving a readonly file duplicates the file
fix: TestableIO#870 Moving a readonly file duplicates the file
fix: #870 Moving a readonly file duplicates the file (#873)
github-actions commentedon Aug 15, 2022
This is addressed in release v17.0.28.
fix: TestableIO#870 Moving a readonly file duplicates the file (Testa…
fix: move a read-only file
fix: move a read-only file (#1239)