IDirectoryInfoFactory.Wrap loses part of absolute path when used with MockFileSystem

Describe the bug
If you provide the MockFileSystem's DirectoryInfo.Wrap method with a DirectoryInfo that has an absolute path, the resulting IDirectoryInfo has the wrong file path.

To Reproduce

using Xunit;
using System.IO.Abstractions;
using System.IO.Abstractions.TestingHelpers;

[Fact]
public void Test()
{
    var fs = new MockFileSystem();
    var directoryInfo = new DirectoryInfo(@"C:\subfolder\file");
    var wrappedDirectoryInfo = fs.DirectoryInfo.Wrap(directoryInfo);

    Assert.Equal(directoryInfo.FullName, wrappedDirectoryInfo.FullName); // wrappedDirectoryInfo returns "C:\file"
}

Expected behaviour
The test above is expected to pass.

Actual behaviour

Assert.Equal() Failure
             ↓ (pos 3)
Expected: C:\subfolder\file
Actual:   C:\file
             ↑ (pos 3)

Additional context
Tested on Windows 10, .Net 7, System.IO.Abstractions version 19.2.69

@koyote

Thanks for reporting and sorry for the late response @koyote! Do you know if this has ever worked?

@fgreinacher

Hi @fgreinacher, I do not, no.
I just recently started using this library and quickly encountered the above bug.

But just looking at the code for DirectoryInfo.Wrap:

public IDirectoryInfo Wrap(DirectoryInfo directoryInfo)
{
    if (directoryInfo == null)
    {
        return null;
    }

    return new MockDirectoryInfo(mockFileSystem, directoryInfo.Name);
}

It looks like it's sending in directoryInfo.Name, which is only the dir name, not the full path.
I'd assume changing that to directoryInfo.FullName would fix it but I don't quite have time at the moment to verify that; maybe this weekend.

Please note, that the same issue also applies when wrapping a FileInfo. I fixed both issues with #1079.

fix: use correct path for wrapped `FileInfo` and `DirectoryInfo` (#1079)

This is addressed in release v20.0.15.

Navigation Menu

Repository navigation

IDirectoryInfoFactory.Wrap loses part of absolute path when used with MockFileSystem #1049

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

IDirectoryInfoFactory.Wrap loses part of absolute path when used with MockFileSystem #1049

Description

Activity

fgreinacher commented on Jan 9, 2024

koyote commented on Jan 9, 2024

vbreuss commented on Jan 22, 2024

github-actions commented on Jan 22, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions