You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Move ExistsAndIsVisible from IPageReader to IElementAssert and IWait #108
Ah right - yes it is an assertion, but I also had a need the other day for waiting until an element was visible (some JavaScript made an Ajax call and when it finished the element was shown).
I definitely think the WaitFor one is quite helpful too. We could use this as a reference to implement a few useful common methods for assertion and waiting.
Activity
robdmoore commentedon Sep 30, 2013
It's kind of an assertion really isn't it?
I agree it doesn't make sense to say Read.ExistsAndIsVisible...
robdmoore commentedon Nov 28, 2013
Should this be
WaitFor.VisibleElement(By....)?MehdiK commentedon Nov 30, 2013
I think this is an assertion. Perhaps something like
AssertThatElements.ExistAndAreVisible()robdmoore commentedon Dec 1, 2013
Ah right - yes it is an assertion, but I also had a need the other day for waiting until an element was visible (some JavaScript made an Ajax call and when it finished the element was shown).
MehdiK commentedon Dec 1, 2013
I definitely think the WaitFor one is quite helpful too. We could use this as a reference to implement a few useful common methods for assertion and waiting.