Repository navigation
fix(test): line the test steps text header up with its columns - #714
Conversation
The header glued the two-character failure-marker column straight onto INDEX, while each row joins the marker as its own cell with a two-space gap, so every heading sat two columns left of its values. Build the header with the same join as the rows. Rows, the error: continuation line and --output json are unchanged. Closes TestSprite#687
|
No actionable comments were generated in the recent review. WalkthroughThe ChangesTest steps text table alignment
Estimated code review effort: 1 (Trivial) | ~5 minutes Severity of issue fixed: Low Merge Risk:
|
What does this PR do?
test stepsin text mode printed every heading two columns left of its values.renderStepsTextbuilt the header aspad(' ', 2) + pad('INDEX', …) + ' ' + …, gluing the marker column ontoINDEX, while each row is[marker, index, …].join(' '). The header now uses the samejoin(' ')as the rows, marker column included.Before / after (
testsprite --dry-run test steps t1):Rows, the
error:continuation line and--output jsonare unchanged.Related issue
Closes #687
Season 4 CLI Improvement Bonus
Discord username: idabagus10
Type of change
Checklist
mainbranch.feat(...),fix(...),docs(...), …).npm run lintandnpm run format:checkpass.npm run typecheckpasses.npm testpasses and coverage stays at or above the 80% gate.README.md/DOCUMENTATION.mdwhere relevant.Notes for reviewers
src/commands/test.test.tsrenders a normal row and a*-marked row and checks each heading starts at its value's offset. On currentmainit fails withINDEX … expected 4 to be 2.BONUS_CLOSES_ATOct 30 06:59 UTC), while the issue itself was filed on Oct 27. Could you let me know whether it can still count as an entry?Summary by CodeRabbit