Repository navigation
Accept driver and passenger temperatures in Tessie set_temperatures - #226
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Code Review ✅ Approved 🟡 Medium riskAdding separate driver and passenger temperature parameters changes Tessie climate commands; incorrect values could set cabin zones to unintended temperatures. Adds driver_temperature and passenger_temperature to TessieVehicle.set_temperatures so the driver and passenger zones can be set separately, and makes temperature optional, sending only the parameters provided. The new parameters follow max_attempts, so existing positional calls remain compatible. No issues found. VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Approved For more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 7 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
Tessie's
set_temperaturescommand also takesdriver_temperatureandpassenger_temperature, so the driver and passenger zones can be set separately.TessieVehicle.set_temperaturesnow accepts both, andtemperatureis optional; only the parameters given are sent. The new parameters followmax_attempts, so existing positional calls keep working.