Skip to content

Accept driver and passenger temperatures in Tessie set_temperatures - #226

Merged
Bre77 merged 1 commit into
mainfrom
fm/tessie-set-temps-passenger
Nov 12, 2026
Merged

Bre77 merged 1 commit into
mainfrom
fm/tessie-set-temps-passenger

Conversation

@Bre77

@Bre77 Bre77 commented Nov 12, 2026

Copy link
Copy Markdown
Member

Tessie's set_temperatures command also takes driver_temperature and passenger_temperature, so the driver and passenger zones can be set separately. TessieVehicle.set_temperatures now accepts both, and temperature is optional; only the parameters given are sent. The new parameters follow max_attempts, so existing positional calls keep working.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

TessieVehicle.set_temperatures now accepts a shared temperature or separate driver and passenger temperatures. It passes these values as request parameters. Tests cover keyword and positional calls, and the documentation shows separate temperatures.

Changes: Temperature inputs

Layer / File(s) Summary
Temperature command inputs
tesla_fleet_api/tessie/vehicle.py, tests/test_tessie_vehicle_params.py, docs/tessie.md
set_temperatures accepts optional shared, driver, and passenger temperatures and passes them to the request. Tests cover keyword and positional arguments. The documentation example uses separate driver and passenger temperatures.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: claude

Merge Risk: Minimal · up to 006e3

This change lets callers set driver and passenger temperatures separately, and existing positional calls keep working. No merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: Tessie set_temperatures now accepts driver and passenger temperatures. The changeset adds driver_temperature and passenger_temperature parameters to TessieVehicle.set_…
Description check Passed The description states that set_temperatures accepts driver_temperature and passenger_temperature, that temperature is now optional, and that only the parameters provided are sent. It also notes that …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: Tessie set_temperatures now accepts driver and passenger temperatures. The changeset adds driver_temperature and passenger_temperature parameters to TessieVehicle.set_temperatures, and the diff matches this title.

Full details: Description check

Explanation

The description states that set_temperatures accepts driver_temperature and passenger_temperature, that temperature is now optional, and that only the parameters provided are sent. It also notes that the new parameters follow max_attempts to keep positional calls working. This matches the changeset.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between be29b6f and 006e3dc.

Files selected for processing: 3

  • docs/tessie.md
  • tesla_fleet_api/tessie/vehicle.py
  • tests/test_tessie_vehicle_params.py

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

@gitar-bot

gitar-bot Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved 🟡 Medium risk

Adding separate driver and passenger temperature parameters changes Tessie climate commands; incorrect values could set cabin zones to unintended temperatures.

Adds driver_temperature and passenger_temperature to TessieVehicle.set_temperatures so the driver and passenger zones can be set separately, and makes temperature optional, sending only the parameters provided. The new parameters follow max_attempts, so existing positional calls remain compatible. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Approved

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 7 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

@Bre77
Bre77 merged commit 3537ddf into main Nov 12, 2026
8 checks passed
@Bre77
Bre77 deleted the fm/tessie-set-temps-passenger branch November 12, 2026 11:16
@Bre77 Bre77 mentioned this pull request Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant