Skip to content

[BUG] Some files don't export correctly due to AttributeError #326

Closed

Description

Extract-msg version 0.38.4 has a bug that causes some files to fail to export if the top of the red-black tree happens to end up as a storage instead of a stream. This is because the top of the tree is the only part that doesn't actually check the type of the node.

This will be fixed by ensuring all nodes are _DirectoryEntrys instead of mixing dicts into it for no reason.

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Program Files\Python39\lib\site-packages\extract_msg\msg.py", line 515, in export
    writer.write(path)
  File "C:\Program Files\Python39\lib\site-packages\extract_msg\ole_writer.py", line 765, in write
    entries = self._writeDirectoryEntries(f, offset)
  File "C:\Program Files\Python39\lib\site-packages\extract_msg\ole_writer.py", line 465, in _writeDirectoryEntries
    entries = self._treeSort(startingSector)
  File "C:\Program Files\Python39\lib\site-packages\extract_msg\ole_writer.py", line 310, in _treeSort
    entry.childID = entry.childTreeRoot.id if entry.childTreeRoot else 0xFFFFFFFF
AttributeError: 'dict' object has no attribute 'id'

Activity

  1. added
    Nearly FixedThis issue has nearly been fixed, and the fix will likely be coming within the next few days
    In ProgressThis issue or feature request has been confirmed or approved, respectively, and is being worked on.
    on Jan 15, 2023
  2. TheElementalOfDestruction commented on Jan 18, 2023

    @TheElementalOfDestruction
    CollaboratorAuthor

    Fixed in 0.39.0

  3. added and removed
    Nearly FixedThis issue has nearly been fixed, and the fix will likely be coming within the next few days
    In ProgressThis issue or feature request has been confirmed or approved, respectively, and is being worked on.
    on Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions