Repository navigation
refactor: migrate deprecated apis - #78
Merged
Merged
Conversation
The backend deprecated several routes on 2026-10-21 and now returns
avatar IDs with the listings that show users.
- Call /api/maiscore/* instead of the deprecated routes:
leaderboard/chart/by-id for GET maichart/{id}/score,
leaderboard/period for POST playhistory/ranking, and
sum/chart/by-uploader/{uploader} for GET stats/score-sums?uploader=.
- Drop the deprecated CommentPage.commentCount field from the types.
- Load every avatar through GET /api/avatar/{avatarId} with the new
UserAvatar component and useAvatarUrl hook; remove the
account/icon?username= endpoint from the frontend.
- Use the avatarId that score sums (player), the season leaderboard
(player), comments (authorProfile) and the chart leaderboard
(player.avatarId) now carry; only chart uploaders and rows without a
profile still read the public profile, once per username.
- Add UserBrief and the new optional fields to the types.
- Update tests, the e2e API mocks and api-directory.md.
Every case failed before reaching the mascot: the image mock served
public/xxlb.jpg, which was removed with the unused assets, and the song
page went blank because the comments mock returned an array.
- Serve covers and avatars from an inline 1x1 PNG instead of a file in
public/.
- Answer GET maichart/{id}/comments with an empty comment page.
- Answer interactsum in the current shape: one summary for the single
GET and one per chart ID for the batch POST.
LingFeng-bbben
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.