This repository was archived by the owner on Jul 25, 2025. It is now read-only.
Repository navigation
Move networktables into strongback - #1
Merged
Merged
Conversation
Set all items present to false in config.
…to PhoenixUpdate
Phoenix update
Logging restarts on enable.
…to colourWheelSolenoid
New Shooter Subsystem
…to colourWheelSolenoid
Colour wheel Solenoid + Get colour from FMS
Template for Pull Requests
…s for defaults. (strongback#97) * Beginnings of a more simple config file. * Getting closer to unit testing and better config layout. * Swap to Config from RobotConfiguration Move more parameters to config so that it can be removed from Constants. Put Constaints on a diet to remove redundant values. Add ConfigReader unit test. Stop passing config everywhere, using a static instance instead. Use namespaces in Config class for better grouping and more consistency. * Ensure example config is written out. * Separate logging and charting. Move to static methods so that they don't need to be passed around. * Rename method to make it consistent * Add unit test for TimestampedLogWriter. * Move things around to reove a class as per pull request. * Changes from reivew. Renamed Logger->Log and other minor changes.
But you did complain didn't you Hayley
But you did complain didn't you Hayley
Templates for Issues
Cache Auto Splines
* Beginnings of a more simple config file. * Getting closer to unit testing and better config layout. * Swap to Config from RobotConfiguration Move more parameters to config so that it can be removed from Constants. Put Constaints on a diet to remove redundant values. Add ConfigReader unit test. Stop passing config everywhere, using a static instance instead. Use namespaces in Config class for better grouping and more consistency. * Ensure example config is written out. * Separate logging and charting. Move to static methods so that they don't need to be passed around. * Rename method to make it consistent * Add unit test for TimestampedLogWriter. * Move things around to reove a class as per pull request. * Changes from reivew. Renamed Logger->Log and other minor changes. * Move constants into Config class. * Merge fixes * Remove redundant line.
Renamed subsystem interfaces
…java/org/strongback'
Author
|
Hmm. 500+ commits. Definitely going to squash this when we merge... There must be a way to only push the commits which concern the files in this repo |
mrwaldron
approved these changes
Jun 30, 2020
CarlinWilliamson
added a commit
that referenced
this pull request
Apr 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The networktables interface is already in strongback so lets move the implementation and mock too using the magic of subtrees!
Here are the changes as seen from the Strongback repo. Go to team3132/2020CompRobot#120 for what it looks like in the CompRobot repo