Skip to content

Fix/#31 - #33

Merged
holmir97 merged 40 commits into
developfrom
fix/#31
Sep 13, 2021
Merged

Fix/#31#33
holmir97 merged 40 commits into
developfrom
fix/#31

Conversation

@holmir97

@holmir97 holmir97 commented Aug 30, 2021

Copy link
Copy Markdown
Member

auth api

  • 이메일 유효성 검사 라이브러리 추가
  • userInterest 모델 삭제로 인한 api fix
  • jwt import 오류 fix

@holmir97
holmir97 requested review from hyundang and xxeol2 August 30, 2021 07:10
hyundang
hyundang reviewed Sep 6, 2021
View reviewed changes

@hyundang hyundang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 리뷰 끝~~

Comment thread src/library/validator.ts

const validator = { emailValidator };

export default validator;

@hyundang hyundang Sep 6, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제 브랜치에 express-validator 라이브러리 이용해서 email 형식 검사하는 미들웨어 추가해놔서 이 부분은 없어도 될 거 같아용

@holmir97 holmir97 Sep 6, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주중에 fix하겠습니다~

Comment thread src/service/authService.ts Outdated
return -1;
}

// 1. 이메일 형식 검사

@hyundang hyundang Sep 6, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

미들웨어 사용하는 걸로 바꾸면 좋을 거 같아여

@holmir97 holmir97 Sep 6, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

미들웨어 추가하겠습니다!

xxeol2 and others added 13 commits September 6, 2021 20:46
@xxeol2
fix: noticeDTO response Body 이름 수정
7bee107
@holmir97
Merge pull request #32 from Team-O2/feat/#26
f59b5e7 
Feat/#26
@hyundang
Feat/#24 (#36)
484ce49 
* fix: UserInterest 삭제

* chore: 이메일 텍스트 변경

* refactor: middleware type 추가

* feat: typecheck middleware 추가

* feat: authDTO 추가

* feat: 이메일 인증번호 전송, 확인, 비밀번호 변경 api 구현

* feat: controller 연결

* feat: router 연결

typeCheck middleware 추가
@holmir97
Merge branch 'develop' into feat/#22
616c8dd
@holmir97
Merge pull request #34 from Team-O2/feat/#22
180c56e 
feat: notice API
@holmir97 Go Seongyong
fix: delete userInterest model
af90a28
@holmir97 Go Seongyong
fix: jwt library import
e44c582
@holmir97 Go Seongyong
feat: email validator
cde383a
@holmir97 Go Seongyong
feat: email validator index
074f624
@holmir97 Go Seongyong
fix: email validator
9ee645f
@holmir97
fix: email validator
a0e8654
Go Seongyong
Merge remote-tracking branch 'origin/fix/#31' into fix/#31
df06c96
@holmir97
fix: validator
ef9f85f
@holmir97
holmir97 merged commit 022b7e7 into develop Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyundang hyundang hyundang left review comments
@xxeol2 xxeol2 Awaiting requested review from xxeol2

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@holmir97 @hyundang @xxeol2