Repository navigation
🔒 Fix Directory Traversal in tar unpack - #248
Tcode-Motion wants to merge 1 commit into
Conversation
The `untar_archive` function incorrectly used `a.unpack()` which does not have built-in directory traversal protections. It has been updated to iterate over `a.entries()` and use `.unpack_in()` on each entry to prevent writing outside the destination directory. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Fixed a Directory Traversal vulnerability in the
⚠️ Risk: The previous implementation used
untar_archivefunction instdlib/src/compress.rs.tar::Archive::unpack(), which does not provide built-in directory traversal protections. An attacker could provide a malicious tarball with paths like../../etc/passwd, allowing them to write files outside of the intended extraction destination directory and potentially overwrite critical system files or source code.🛡️ Solution: The implementation was updated to manually iterate over
a.entries()and callentry.unpack_in(dest_dir). Theunpack_inmethod contains built-in sanity checks that prevent paths containing..or absolute paths from escaping the target extraction directory.PR created automatically by Jules for task 15510206791587803934 started by @Tcode-Motion