Skip to content

🔒 Fix Directory Traversal in tar unpack - #248

Open
Tcode-Motion wants to merge 1 commit into
mainfrom
fix-tar-directory-traversal-15510206791587803934
Open

Tcode-Motion wants to merge 1 commit into
mainfrom
fix-tar-directory-traversal-15510206791587803934

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: Fixed a Directory Traversal vulnerability in the untar_archive function in stdlib/src/compress.rs.
⚠️ Risk: The previous implementation used tar::Archive::unpack(), which does not provide built-in directory traversal protections. An attacker could provide a malicious tarball with paths like ../../etc/passwd, allowing them to write files outside of the intended extraction destination directory and potentially overwrite critical system files or source code.
🛡️ Solution: The implementation was updated to manually iterate over a.entries() and call entry.unpack_in(dest_dir). The unpack_in method contains built-in sanity checks that prevent paths containing .. or absolute paths from escaping the target extraction directory.


PR created automatically by Jules for task 15510206791587803934 started by @Tcode-Motion

The `untar_archive` function incorrectly used `a.unpack()` which does not have built-in directory traversal protections. It has been updated to iterate over `a.entries()` and use `.unpack_in()` on each entry to prevent writing outside the destination directory.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
github-actions Bot marked this pull request as ready for review October 7, 2026 13:10

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant