Skip to content

Fix(virtual-core): Wrap ResizeObserver callbacks in window.requestAnimationFrame to avoid error #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samstronghammer wants to merge 1 commit into from
Closed

Fix(virtual-core): Wrap ResizeObserver callbacks in window.requestAnimationFrame to avoid error #842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions packages/virtual-core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,17 @@ export const observeElementRect = <T extends Element>(
}

const observer = new targetWindow.ResizeObserver((entries) => {
const entry = entries[0]
if (entry?.borderBoxSize) {
const box = entry.borderBoxSize[0]
if (box) {
handler({ width: box.inlineSize, height: box.blockSize })
return
window.requestAnimationFrame(() => {
const entry = entries[0]
if (entry?.borderBoxSize) {
const box = entry.borderBoxSize[0]
if (box) {
handler({ width: box.inlineSize, height: box.blockSize })
return
}
}
}
handler(element.getBoundingClientRect())
handler(element.getBoundingClientRect())
})
})

observer.observe(element, { box: 'border-box' })
Expand Down Expand Up @@ -363,8 +365,10 @@ export class Virtualizer<
}

return (_ro = new this.targetWindow.ResizeObserver((entries) => {
entries.forEach((entry) => {
this._measureElement(entry.target as TItemElement, entry)
window.requestAnimationFrame(() => {
entries.forEach((entry) => {
this._measureElement(entry.target as TItemElement, entry)
})
})
}))
}
Expand Down