Skip to content

fix(virtual-core): ensure getTotalSize returns 0 for empty list - #836

Merged
piecyk merged 1 commit into
TanStack:mainfrom
lucasweng:fix/negative-total-size
Sep 16, 2024
Merged

piecyk merged 1 commit into
TanStack:mainfrom
lucasweng:fix/negative-total-size

Conversation

@lucasweng

Copy link
Copy Markdown
Contributor

@nx-cloud

nx-cloud Bot commented Sep 16, 2024 •

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5d1da8e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new

pkg-pr-new Bot commented Sep 16, 2024

Copy link
Copy Markdown

Open in Stackblitz

More templates

@tanstack/lit-virtual

pnpm add https://pkg.pr.new/@tanstack/lit-virtual@836

@tanstack/angular-virtual

pnpm add https://pkg.pr.new/@tanstack/angular-virtual@836

@tanstack/react-virtual

pnpm add https://pkg.pr.new/@tanstack/react-virtual@836

@tanstack/solid-virtual

pnpm add https://pkg.pr.new/@tanstack/solid-virtual@836

@tanstack/virtual-core

pnpm add https://pkg.pr.new/@tanstack/virtual-core@836

@tanstack/svelte-virtual

pnpm add https://pkg.pr.new/@tanstack/svelte-virtual@836

@tanstack/vue-virtual

pnpm add https://pkg.pr.new/@tanstack/vue-virtual@836

commit: 5d1da8e

@piecyk
piecyk merged commit 9f8ac01 into TanStack:main Sep 16, 2024
@lucasweng
lucasweng deleted the fix/negative-total-size branch September 16, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getTotalSize reports a negative value for empty list when scrollMargin is set

2 participants