Skip to content

feat: add rangeExtractor - #164

Merged
tannerlinsley merged 1 commit into
TanStack:masterfrom
piecyk:feat/range-extractor
Jul 13, 2021
Merged

tannerlinsley merged 1 commit into
TanStack:masterfrom
piecyk:feat/range-extractor

Conversation

@piecyk

@piecyk piecyk commented Jul 13, 2021

Copy link
Copy Markdown
Collaborator

closes #163

@piecyk
piecyk force-pushed the feat/range-extractor branch from 39a9c38 to 55acb3e Compare July 13, 2021 06:27
@tannerlinsley

Copy link
Copy Markdown
Member

Love this. 🎉

@tannerlinsley
tannerlinsley merged commit b465637 into TanStack:master Jul 13, 2021
@tannerlinsley

Copy link
Copy Markdown
Member

Would you be up to adding an example to both the sandboxes and the docs?

@tannerlinsley

Copy link
Copy Markdown
Member

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@piecyk

piecyk commented Jul 15, 2021

Copy link
Copy Markdown
Collaborator Author

Would you be up to adding an example to both the sandboxes and the docs?

Yes, also would be good to update other example, something is wrong with Infinite Scrolling

@piecyk
piecyk deleted the feat/range-extractor branch July 15, 2021 05:57
@jonahallibone

jonahallibone commented Jul 20, 2021 •

Copy link
Copy Markdown
Contributor

@piecyk Sort of tangentially related, but I saw on the original issue #163 that an isVisible key value was in the works. I am wondering if this value could be used to memoize rows to prevent rerenders on scroll. While this (#164) addition is helpful for performance, I think preventing row rerenders on scroll is probably something that would generally be more helpful for infinite scroll.

@piecyk

piecyk commented Jul 21, 2021

Copy link
Copy Markdown
Collaborator Author

@jonahallibone you can do it now, by using memo on row. One problem is in dynamic context as the measureRef is re-crated for every range change, but you can always have an extra div wrapping the memo item.

Also we can move measureRef to measurements then problem that it's breaking memo will be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Allow keeping already rendered items mounted

3 participants