You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(react-start): wait for SSR between HMR saves - #8913
Wait for the server to render the first loader edit before saving the child route again. This reuses the suite’s existing SSR readiness helper between edits. Both edits still happen on the home page, and the final client navigation still has to show the second loader value.
The second edit timed out in two runs of #8912. The unmodified test passed locally on both pnpm versions, so this PR isolates the synchronization change on the pnpm 11 baseline.
Codex authored this change and PR description.
Validation
Ten focused Chromium repetitions passed on pnpm 11.21.0.
The full HMR target passed, including Vite, Vite bundled dev, and Rsbuild.
I have tested code changes locally with the relevant test commands, or tests do not apply to this pull request.
I fully understand the code in this pull request, including any code generated with AI assistance.
🚀 Release Impact
This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).
Summary by CodeRabbit
Tests
Improved coverage for development-time updates by verifying that refreshed child content appears in the server-rendered page before a subsequent edit. This helps catch issues where updated content is not visible after an initial change.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
No actionable comments were generated in the recent review.
Walkthrough
The child-loader HMR test now waits for hydration-safe server-rendered HTML containing Child Updated after the first loader edit and before making the second edit.
Changes: Child-loader HMR test
Layer / File(s)
Summary
Wait for the first child-loader update e2e/react-start/hmr/tests/app.spec.ts
The test waits for server-rendered HTML to contain Child Updated after the first loader edit and before the second edit.
The test waits for the first server-rendered update before the second edit. No merge-blocking risk was identified.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title "test(react-start): wait for SSR between HMR saves" matches the change. The PR makes the child-loader HMR test wait for the server to render the first loader edit before the second save. The…
Description check
The description covers the change and its motivation. It explains the SSR wait between the two loader edits, the timeout seen in #8912, and the validation runs (Chromium repetitions on pnpm 11.21.0 an…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "test(react-start): wait for SSR between HMR saves" matches the change. The PR makes the child-loader HMR test wait for the server to render the first loader edit before the second save. The title names the test scope, the synchronization change, and the affected suite. It is concise and specific, and it does not describe anything absent from the changeset.
Full details: Description check
Explanation
The description covers the change and its motivation. It explains the SSR wait between the two loader edits, the timeout seen in #8912, and the validation runs (Chromium repetitions on pnpm 11.21.0 and the full HMR target). It also includes the checklist and release-impact sections from the template. Two checklist items are incomplete: the box for fully understanding the code, including AI-assisted code, is unchecked, and the AI-authorship disclosure is present but the author has not confirmed understanding. The release-impact choice is marked as docs/CI/dev-only, which fits a test-only change.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 70bbd11 and f578e6a.
Files selected for processing: 1
e2e/react-start/hmr/tests/app.spec.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
Takes main's pnpm 12 upgrade (#8912), the RSC dependency bump (#8919) and
the react-start HMR e2e fix (#8913).
The lockfile is main's, regenerated with pnpm 12 for the slice's packages.
pnpm 12 merges a version a package names directly into the other
packages' ranges, so two ranges of the slice are set to the versions main
already resolves, to leave every other package's resolution as on main:
the harness's `esbuild` (^0.28.1; ^0.28.2 added a second esbuild and moved
webpack's peer variant) and router-plugin's `@babel/preset-typescript`
(7.27.1; ^7.28.5 moved esbuild-plugin-solid's preset and the preset's own
helpers). The only change left outside the slice's packages is the css-modules
e2e apps' sass bump.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Wait for the server to render the first loader edit before saving the child route again. This reuses the suite’s existing SSR readiness helper between edits. Both edits still happen on the home page, and the final client navigation still has to show the second loader value.
The second edit timed out in two runs of #8912. The unmodified test passed locally on both pnpm versions, so this PR isolates the synchronization change on the pnpm 11 baseline.
Codex authored this change and PR description.
Validation
✅ Checklist
🚀 Release Impact
Summary by CodeRabbit