You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(router-plugin): point split routes' source maps at the route file - #8860
Source maps of split routes now point at the route file you wrote.
The fix
webpack, Rspack and Rsbuild: the router plugin's map was dropped. unplugin 3.3.0's webpack/Rspack transform loader returns map == null ? map : res.map || map. The router plugin's loader runs first (enforce: 'pre'), so no earlier loader passes a map in, and our map is thrown away. Later loaders (SWC in Rsbuild) then map against the splitter's output, so a split component maps to the wrong line. Upstream fixed this in unjs/unplugin#626, released in v3.5.0. unplugin now requires ^3.5.0; the lockfile resolves 3.7.0.
All bundlers: split and shared modules named their virtual id. The code splitter passed the module id, index.tsx?tsr-split=component / ?tsr-shared=1, as the map's sourceFileName. It now passes the route file. In Vite dev, devtools used to list index.tsx?tsr-split=component beside index.tsx. With only the unplugin bump, webpack and Rspack get the right line but list the split chunk's source as a separate ./routes/index.js?<hash> entry, so a breakpoint set in the route file doesn't bind there either. Both changes are needed.
After the fix, in the tested setups, each map names one source (the route file) and holds its text as written.
Issues
FixesautoCodeSplitting on Rsbuild breaks source maps #3828. Verified on main with a real Rspack build: the split component's throw maps to line 3 instead of 8. With autoCodeSplitting off, the plugin doesn't transform the file, so no map is lost; that matches the report. Nothing about it is Windows-specific.
Part of Bug: Breakpoints fail to attach in VSCode when autoCodeSplitting is enabled #6667 (VS Code breakpoints with autoCodeSplitting on Vite). This fixes the split module's map naming about.tsx?tsr-split=component instead of the route file. VS Code itself wasn't run, so whether breakpoints now bind there, and the reporter's enableContentValidation workaround, aren't verified.
Tests
packages/router-plugin/tests/source-maps.test.ts uses public entry points only (@tanstack/router-plugin/{webpack,rspack,vite}):
a real webpack build (the plugin is the only loader) and a real Rspack build (with builtin:swc-loader after it, as in Rsbuild): the throw in the split component, and the throw in a function the loader and component share, each map through the emitted .map to their line in routes/index.*;
Vite's dev server: every module derived from the route file maps those throws to their line, and its inline map names /routes/index.tsx, not the ?tsr-* id.
All 3 fail on main, and each change alone leaves at least one failing (checked separately, including each of the 2 sourceFileName sites).
e2e: the 6 Rsbuild router apps ({react,solid,vue}-router/rspack-basic-file-based and …-virtual-named-export-config-file-based, all with autoCodeSplitting) pass. The webpack examples ({react,solid}/quickstart-webpack-file-based) build.
Bundle size (full run, all scenarios): every Vite scenario is byte-identical. The 3 react-start.rsbuild.* scenarios have the same raw bytes and +7 to +14 B gzip. Only Rspack's numeric module and chunk IDs differ (and, in the IIFE build, the minified names derived from them), because those IDs hash each module's loader request, which contains unplugin's versioned install path. No code changes.
Lockfile: unplugin 3.3.0 → 3.7.0, plus its new @rolldown/pluginutils dependency and optional @rsbuild/core peer. pnpm's re-resolution also moved one existing @typescript-eslint/eslint-plugin snapshot from ignore 7.0.5 to 7.0.12; both versions were already in the lockfile, and a no-op pnpm install --no-frozen-lockfile on main doesn't produce it.
start-plugin-core doesn't depend on unplugin; only router-plugin changes.
The new test passes on #8817's head unchanged (webpack, Rspack and Vite). #8817 uses its own webpack/Rspack loader for route modules, so the bump isn't needed for its maps but does no harm.
Real webpack and Rspack builds, and Vite's dev server: a throw in a split
component, and in code it shares, maps to its line in the route file, and
the map names the route file rather than its ?tsr-split / ?tsr-shared id.
Fails on main.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Require unplugin ^3.5.0: its webpack/Rspack transform loader dropped a
plugin's map when no earlier loader passed one (unjs/unplugin#626).
- Name the route file, not the ?tsr-split / ?tsr-shared module id, as the
source of split and shared modules' maps.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No actionable comments were generated in the recent review.
Walkthrough
The router plugin now uses query-free route filenames in source maps for split and shared modules. The dependency range for unplugin is updated, and tests cover webpack, Rspack, and Vite.
Changes: Split source maps
Layer / File(s)
Summary
Use route filenames for source maps packages/router-plugin/src/core/code-splitter/compilers.ts, packages/router-plugin/package.json, .changeset/router-plugin-split-source-maps.md
The split and shared route compilers use query-free route filenames as source-map names. The unplugin range changes to ^3.5.0, and the changeset documents the source-map behavior.
Validate source maps across bundlers packages/router-plugin/tests/source-maps.test.ts
Tests verify that throws in split components and shared code map to route-file lines in webpack and Rspack production builds and Vite development modules.
TanStack/router#8804: Adds Bun code splitting and source maps for tsr-split and tsr-shared modules, mapping transformed modules to route files.
Merge Risk: Minimal · up to 66487
No concrete current-head defect or merge-blocking risk was identified.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 71.43% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title names the main change: split routes' source maps now point at the route file. It matches the changeset, the sourceFileName change in compilers.ts, and the regression tests. It uses the conve…
Description check
The description covers the required template sections. The Changes section explains the root causes, the unplugin bump, and the sourceFileName change, with motivation and issue links (#3828, #6667). T…
Linked Issues check
Active direct target: #3828. Requirement: with autoCodeSplitting enabled on Rspack, the generated source map must name the original route file and map to its lines, so a debugger stops at the source s…
Out of Scope Changes check
Changes at the reviewed head and their link to #3828: - packages/router-plugin/package.json: unplugin ^3.3.0 changed to ^3.5.0. Required for the webpack/Rspack map fix. Confirmed at head. - packages/r…
Full details: Title check
Explanation
The title names the main change: split routes' source maps now point at the route file. It matches the changeset, the sourceFileName change in compilers.ts, and the regression tests. It uses the conventional fix(router-plugin) prefix and is 10 words, which is concise. It does not mention the unplugin bump, but the title does not need to cover every detail.
Full details: Description check
Explanation
The description covers the required template sections. The Changes section explains the root causes, the unplugin bump, and the sourceFileName change, with motivation and issue links (#3828, #6667). The Checklist is not ticked, and the Release Impact section is not ticked either. The changeset file (.changeset/router-plugin-split-source-maps.md) exists per the summary, so the release box should be checked. The description also includes detailed validation and test notes. It is mostly complete. The template checkboxes for the contributing guide and the AI-understanding confirmation are not marked, and the AI-authorship disclosure is present only via the Claude Code footer.
Resolution
Tick the checklist items in the template: the contributing guide item, the local testing item, the understanding-of-code item, and the 'affects published code' changeset item. Add an explicit AI-authorship disclosure line near the top, as the template's AI-authored PR rules request. The current footer mentions Claude Code but does not state the disclosure as a template item.
Full details: Linked Issues check
Explanation
Active direct target: #3828. Requirement: with autoCodeSplitting enabled on Rspack, the generated source map must name the original route file and map to its lines, so a debugger stops at the source statement.
Code evidence at the reviewed head (merge base to head):
packages/router-plugin/package.json: unplugin range is ^3.5.0. This addresses the webpack/Rspack transform loader that dropped the router plugin's map in unplugin 3.3.0. The PR description states the lockfile resolves 3.7.0.
packages/router-plugin/src/core/code-splitter/compilers.ts: compileCodeSplitVirtualRoute and compileCodeSplitSharedRoute now pass removeSplitSearchParamFromFilename(opts.filename) as sourceFileName. Previously they passed the full ?tsr-* module id. This addresses the source naming that the issue depends on.
The PR reports source-map tests in packages/router-plugin/tests/source-maps.test.ts for a real webpack build, a real Rspack build with builtin:swc-loader after the router loader (matching Rsbuild), and Vite dev. The PR reports that these tests fail on main and that each change alone leaves a failure. The test file was not read in this assessment, so the test results rely on the PR report.
Limits: the helper removeSplitSearchParamFromFilename was not inspected in this assessment. The VS Code breakpoint binding from the issue was not run, as the PR states. The fix is verified at the source-map level, which is the mechanism the issue depends on. The PR reports the issue's Windows environment is not a limit on the fix. No unmet coding requirement was found.
Full details: Out of Scope Changes check
Explanation
Changes at the reviewed head and their link to #3828:
packages/router-plugin/package.json: unplugin ^3.3.0 changed to ^3.5.0. Required for the webpack/Rspack map fix. Confirmed at head.
packages/router-plugin/src/core/code-splitter/compilers.ts: two sourceFileName sites changed to the route filename without the ?tsr-* query, with comments. Confirmed in the whole-PR diff. Directly implements the naming fix.
packages/router-plugin/tests/source-maps.test.ts: regression tests for webpack, Rspack, and Vite source maps. Supports the objective. Not read in this assessment.
.changeset/router-plugin-split-source-maps.md: patch changeset for the two changes. Release documentation for this fix.
pnpm-lock.yaml: the unplugin move from 3.3.0 to 3.7.0 and its new transitive dependency follow from the package.json bump. The PR also reports one transitive resolution change, @typescript-eslint/eslint-plugin's ignore dependency from 7.0.5 to 7.0.12, attributed to pnpm re-resolution. The lockfile diff could not be read in this assessment, so this is not independently verified. The change does not show unrelated feature work, and the PR reports no source-level effect.
No change was found that lacks a connection to the #3828 source-map objective. The PR references #6667, which is not a linked issue in this review, so it was not assessed.
Full details: Docstring Coverage
Explanation
Docstring coverage is 71.43% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 7 functions across 2 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 97640c1 and 664878d.
Files selected for processing: 1
packages/router-plugin/tests/source-maps.test.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
The following scenarios have bundle-size changes compared with the baseline:
Scenario
Current (gzip)
Initial (gzip)
Raw
Brotli
Trend
react-start.rsbuild.minimal
100.4 KiB +9 B
100.2 KiB +10 B
313.3 KiB 0 B
86.6 KiB +21 B
▁▁▁▁▁▁▁▁▁▁▁█
react-start.rsbuild.minimal-iife
100.8 KiB +14 B
100.6 KiB +15 B
314.2 KiB 0 B
87.0 KiB +3 B
▁▁▁▁▁▁▁▁▁▁▁█
react-start.rsbuild.full
103.5 KiB +7 B
103.4 KiB +8 B
322.9 KiB 0 B
89.3 KiB -117 B
▁▁▁▁▁▁▁▁▁▁▁█
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
…he app
runCompiler settled before compiler.close finished, so the test could remove
the app while webpack or Rspack was still shutting down, and a close error
went unreported.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.
⚠️2 benchmarks with a significant change ran on different hardware
Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.
#8817's side for the split-out PRs:
- #8861 (Start router options): the PR's generator-config, Vite and
Rsbuild wiring; main's start-router-wiring test and start-app helper
dropped (start-build-options, start-dev-route-tree-footer and
start-compose-project-path test the same four behaviours). Main's
changeset kept; the duplicated bullets leave start-compiler-yuku.md.
- #8860 (split route source maps): the PR's own loader; compilers.ts stays
deleted; main's source-maps test dropped (build-source-maps and
dev-source-maps test webpack, Rspack and Vite dev). unplugin ^3.5.0 kept
from main (no downgrade). Main's changeset kept; the PR's source map
clause leaves router-plugin-yuku.md.
- #8653 (visible() hooks): merged to the PR's file, test and changeset
unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… map-name checks
The slice has no test for two behaviours main guards: a webpack or Rspack
production build whose configuration has no `mode` ships no splitter
warning (#8269), and on webpack and Rspack the maps of a split component
and of shared code name the route file, not the `?tsr-split` id (#8860).
Keep those cases of main's tests, cut to what the slice does not cover:
the `mode: 'production'` rows, the line mapping and Vite's dev server are
asserted in the integration tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Source maps of split routes now point at the route file you wrote.
The fix
webpack, Rspack and Rsbuild: the router plugin's map was dropped. unplugin 3.3.0's webpack/Rspack transform loader returns
map == null ? map : res.map || map. The router plugin's loader runs first (enforce: 'pre'), so no earlier loader passes a map in, and our map is thrown away. Later loaders (SWC in Rsbuild) then map against the splitter's output, so a split component maps to the wrong line. Upstream fixed this in unjs/unplugin#626, released in v3.5.0.unpluginnow requires^3.5.0; the lockfile resolves 3.7.0.All bundlers: split and shared modules named their virtual id. The code splitter passed the module id,
index.tsx?tsr-split=component/?tsr-shared=1, as the map'ssourceFileName. It now passes the route file. In Vite dev, devtools used to listindex.tsx?tsr-split=componentbesideindex.tsx. With only the unplugin bump, webpack and Rspack get the right line but list the split chunk's source as a separate./routes/index.js?<hash>entry, so a breakpoint set in the route file doesn't bind there either. Both changes are needed.After the fix, in the tested setups, each map names one source (the route file) and holds its text as written.
Issues
autoCodeSplittingoff, the plugin doesn't transform the file, so no map is lost; that matches the report. Nothing about it is Windows-specific.autoCodeSplittingis enabled #6667 (VS Code breakpoints withautoCodeSplittingon Vite). This fixes the split module's map namingabout.tsx?tsr-split=componentinstead of the route file. VS Code itself wasn't run, so whether breakpoints now bind there, and the reporter'senableContentValidationworkaround, aren't verified.Tests
packages/router-plugin/tests/source-maps.test.tsuses public entry points only (@tanstack/router-plugin/{webpack,rspack,vite}):builtin:swc-loaderafter it, as in Rsbuild): the throw in the split component, and the throw in a function the loader and component share, each map through the emitted.mapto their line inroutes/index.*;/routes/index.tsx, not the?tsr-*id.All 3 fail on main, and each change alone leaves at least one failing (checked separately, including each of the 2
sourceFileNamesites).Validation
@tanstack/router-plugin:test:unit(21 files, 902 passed),test:types,test:eslint,test:buildpass.{react,solid,vue}-router/rspack-basic-file-basedand…-virtual-named-export-config-file-based, all withautoCodeSplitting) pass. The webpack examples ({react,solid}/quickstart-webpack-file-based) build.react-start.rsbuild.*scenarios have the same raw bytes and +7 to +14 B gzip. Only Rspack's numeric module and chunk IDs differ (and, in the IIFE build, the minified names derived from them), because those IDs hash each module's loader request, which contains unplugin's versioned install path. No code changes.@rolldown/pluginutilsdependency and optional@rsbuild/corepeer. pnpm's re-resolution also moved one existing@typescript-eslint/eslint-pluginsnapshot fromignore7.0.5 to 7.0.12; both versions were already in the lockfile, and a no-oppnpm install --no-frozen-lockfileon main doesn't produce it.With #8817
This is one of the small PRs split out of #8817. Merging #8817's head on top conflicts in:
packages/router-plugin/package.json: adjacent lines. Take refactor(compiler)!: replace Babel with a Yuku-based compiler core for Router and Start #8817's side (nochokidar, addyuku) and keep"unplugin": "^3.5.0".packages/router-plugin/src/core/code-splitter/compilers.ts: refactor(compiler)!: replace Babel with a Yuku-based compiler core for Router and Start #8817 deletes it. Delete.pnpm-lock.yaml: take refactor(compiler)!: replace Babel with a Yuku-based compiler core for Router and Start #8817's and runpnpm install --no-frozen-lockfile. Only unplugin moves (3.3.0 → 3.7.0).The new test passes on #8817's head unchanged (webpack, Rspack and Vite). #8817 uses its own webpack/Rspack loader for route modules, so the bump isn't needed for its maps but does no harm.
🤖 Generated with Claude Code
Summary by CodeRabbit