Skip to content

fix: deletion of subitems on a field now works - #1199

Merged
crutchcorn merged 2 commits into
mainfrom
delete-field-works-for-subitems
Mar 2, 2025
Merged

crutchcorn merged 2 commits into
mainfrom
delete-field-works-for-subitems

Conversation

@crutchcorn

Copy link
Copy Markdown
Contributor

Thanks to @LeCarbonator for the report and test

@nx-cloud

nx-cloud Bot commented Mar 2, 2025 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 72b3c1c.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 39s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-02 01:44:31 UTC

@pkg-pr-new

pkg-pr-new Bot commented Mar 2, 2025

Copy link
Copy Markdown

@codecov

codecov Bot commented Mar 2, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (230c2a0) to head (72b3c1c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1199      +/-   ##
==========================================
+ Coverage   88.70%   88.73%   +0.03%     
==========================================
  Files          28       28              
  Lines        1257     1261       +4     
  Branches      329      330       +1     
==========================================
+ Hits         1115     1119       +4     
  Misses        127      127              
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crutchcorn
crutchcorn merged commit 72a09c3 into main Mar 2, 2025
@crutchcorn
crutchcorn deleted the delete-field-works-for-subitems branch March 2, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant