Repository navigation
perf: reuse stable SVG sibling order - #268
tannerlinsley wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
🦋 Changeset detectedLatest commit: 394594d The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 394594d
💡 With Ultracache enabled, Nx Cloud learns each task's file inputs in CI and uses them on later runs. Turn on Ultracache in workspace settings ↗ · Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Dense SVG updates rebuild sibling identity maps even when every child keeps the same position. This adds a guarded same-order path for non-animated, element-only siblings with unique keys. Reorders, duplicate keys, text and animation retain the existing fallback.
The isolated 1.5.0 React fixture with 10,000 circles measured 7.0-10.8% lower synchronous update time over four reversed-order rounds, with identical final output. This excludes paint and is not a competitor comparison. Repeated lifecycle memory and animation differential controls passed. Current-repository performance refresh remains before landing.
Validation on b236dae:
Owner decision needed before landing: approve these exact size increases for the measured benefit, decline, or defer. Recommendation: approve the bounded exception, subject to remaining compatibility, current-source performance and normal CI/review gates.
Approval would authorize updating only these exact locked rows and ceilings after remaining gates pass. It would not waive CI, review, correctness, performance or other budgets. This is a draft awaiting that decision, not a shipping-ready claim.