Repository navigation
Add renderer-neutral radial gradients - #147
Merged
Merged
Conversation
…s locale-independent
A y scale with `side: 'right'` took its tick-label anchor from the physical side alone. That anchor reaches the DOM as SVG `text-anchor`, which resolves against inline base direction, so an RTL container painted the labels leftward into the plot. The margin pass then read those bounds correctly and reserved nothing on the right, widening the plot until it ran under its own labels. Anchor the far side with `end` once the container reads right to left, and mirror the same relation in the text estimator so a host without a DOM measurer resolves the identical layout.
The layout fix costs 73 B raw in shared code, which puts the difference-mark increment 0.02 kB over its ceiling. Gzip falls on most entries.
# Conflicts: # benchmarks/conformance/cases/103-bubble-map/tanstack.ts # benchmarks/conformance/cases/34-pointer-tooltip/tanstack.ts # benchmarks/conformance/cases/83-focus-context-window/view.tsx # benchmarks/conformance/cases/86-streaming-window-preservation/view.tsx # benchmarks/conformance/cases/88-echarts-free-cursor/controls.ts # benchmarks/conformance/cases/91-timeline-playback-scrubber/tanstack.ts # benchmarks/conformance/cases/92-editable-event-range/tanstack.ts
|
Warning Review limit reachedNext included review available in 30 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (31)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (41)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe PR adds renderer-neutral linear and radial gradient types. SVG, Canvas, and React Native now support radial gradient resources with normalized coordinates, stop normalization, renderer-specific fill and stroke behavior, reconciliation updates, tests, documentation, and refreshed bundle measurements. ChangesGradient support
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Severity of issue fixed: Medium Sequence Diagram(s)sequenceDiagram
participant ChartSpec
participant SVGRenderer
participant CanvasRenderer
participant ReactNativeAdapter
ChartSpec->>SVGRenderer: provide linear or radial gradient
ChartSpec->>CanvasRenderer: provide linear or radial gradient
ChartSpec->>ReactNativeAdapter: provide linear or radial gradient
SVGRenderer->>SVGRenderer: emit SVG gradient resources
CanvasRenderer->>CanvasRenderer: clip and paint radial fills
ReactNativeAdapter->>ReactNativeAdapter: emit react-native-svg resources
Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 26 functions across 17 files. (24 skipped: 24 unsupported.) ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 2e038b0
☁️ Nx Cloud last updated this comment at |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Canvas boundary
Canvas radial gradients support fills. Radial strokes throw a clear error because a nonuniform objectBoundingBox transform would distort stroke width. SVG and React Native support radial fills and strokes.
Validation
Release
Closes #129
Summary by CodeRabbit
New Features
Documentation