Repository navigation
Fix retargeted focus group motion - #144
Merged
Merged
Conversation
…s locale-independent
A y scale with `side: 'right'` took its tick-label anchor from the physical side alone. That anchor reaches the DOM as SVG `text-anchor`, which resolves against inline base direction, so an RTL container painted the labels leftward into the plot. The margin pass then read those bounds correctly and reserved nothing on the right, widening the plot until it ran under its own labels. Anchor the far side with `end` once the container reads right to left, and mirror the same relation in the text estimator so a host without a DOM measurer resolves the identical layout.
The layout fix costs 73 B raw in shared code, which puts the difference-mark increment 0.02 kB over its ceiling. Gzip falls on most entries.
# Conflicts: # benchmarks/conformance/cases/103-bubble-map/tanstack.ts # benchmarks/conformance/cases/34-pointer-tooltip/tanstack.ts # benchmarks/conformance/cases/83-focus-context-window/view.tsx # benchmarks/conformance/cases/86-streaming-window-preservation/view.tsx # benchmarks/conformance/cases/88-echarts-free-cursor/controls.ts # benchmarks/conformance/cases/91-timeline-playback-scrubber/tanstack.ts # benchmarks/conformance/cases/92-editable-event-range/tanstack.ts
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (11)
🚧 Files skipped from review as they are similar to previous changes (4)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change records focus mark ownership on scene groups, preserves namespacing through composite and embedded scenes, and applies focused mark motion to retargeted structural groups. Tests cover callbacks, disabled motion, point ownership, invalid slots, and nested ownership. Bundle and comparison baselines are refreshed. ChangesFocus group motion
Estimated code review effort: 4 (Complex) | ~45 minutes Severity of issue fixed: Medium Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant FocusMark
participant SceneGroup
participant RetargetContext
participant MotionRenderer
FocusMark->>SceneGroup: emit focus group with markId
SceneGroup->>RetargetContext: provide focus ownership and slot metadata
RetargetContext->>RetargetContext: resolve point and validate slot
RetargetContext->>MotionRenderer: provide markId and motion context
MotionRenderer->>SceneGroup: animate or remove structural group
Merge Risk: ⚪ Minimal · up to The focus-motion update preserves mark ownership across composed and embedded scenes while retaining point-level motion for valid selections. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 9 files. (7 skipped: 7 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 77c7a63
☁️ Nx Cloud last updated this comment at |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #136
Testing
Summary by CodeRabbit
Bug Fixes
Documentation
Chores