You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A for now read-only Calendar app that syncs upcoming events from a CalDAV calendar collection.
Settings for the calendar URL, username, and password, saved with Tactility preferences.
Use authenticated HTTPS CalDAV REPORT requests with certificate validation.
Display events for the next 30 days.
Tested only on T-DECK Plus.
Summary by CodeRabbit
New Features
Added a read-only CalDAV calendar app. Configure a calendar URL and credentials, then sync to view events for the next 30 days.
Calendar events are displayed in start-time order, with cancelled events excluded.
Added an MP3 player that scans SD-card folders, displays track information, and provides playback controls, audio-output selection, and volume adjustment.
Documentation
Added setup guidance for calendar accounts, connectivity, HTTPS certificates, and event time zones, plus music library setup and scanning.
Adds a read-only Calendar app that stores CalDAV account settings and requests events over HTTPS. The app parses CalDAV XML and ICS data, then displays eligible events in start-time order, up to a maximum of 24. Sync requests cover the next 30 days. The app includes an agenda, sync status, and settings panel. Adds a Music Player app that scans SD-card folders for MP3 files, reads ID3 metadata, and provides playback, track selection, and audio output controls.
Merge Risk: Low · previous review 52641
The Calendar and Music Player apps are new and mostly self-contained. A failed CalDAV property response can briefly show an empty agenda. Music playback controls can occasionally ignore a Stop or pick the wrong track under rapid input. These are minor and recoverable, and worth fixing but not blocking.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "Add Calendar app" matches the main change. The PR adds a new read-only CalDAV Calendar app (version 0.2.1), including its CMake setup, manifest, README, settings, sync logic, and UI. The ti…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "Add Calendar app" matches the main change. The PR adds a new read-only CalDAV Calendar app (version 0.2.1), including its CMake setup, manifest, README, settings, sync logic, and UI. The title is short, specific, and free of file lists or vague terms. The PR also adds a Music Player app, which the title does not mention. That omission is expected because the title need not cover every detail.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 944a1b9a-3e33-45eb-95ce-3d02d4f03e62
Commits
Reviewing files that changed from the base of the PR and between cb19c69 and f1d4475.
Files ignored due to path filters: 2
Apps/Calendar/icon.svg is excluded by !**/*.svg
Apps/Calendar/icon_mono.svg is excluded by !**/*.svg
Files selected for processing: 7
Apps/Calendar/CMakeLists.txt
Apps/Calendar/README.md
Apps/Calendar/main/CMakeLists.txt
Apps/Calendar/main/Source/CalendarApp.cpp
Apps/Calendar/main/Source/CalendarApp.h
Apps/Calendar/main/Source/main.cpp
Apps/Calendar/manifest.properties
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Serialize settings writes and the worker's settings reads.
Do not shift retained events a second time.
Read properties only from the VEVENT component.
Find calendar-data elements, not arbitrary text matches.
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 63b7ad56-c421-49a1-9f29-0ec3fb0f549d
Commits
Reviewing files that changed from the base of the PR and between f1d4475 and 526418f.
Files ignored due to path filters: 2
Apps/MusicPlayer/icon.svg is excluded by !**/*.svg
Apps/MusicPlayer/icon_mono.svg is excluded by !**/*.svg
Files selected for processing: 11
Apps/Calendar/main/Source/CalendarApp.cpp
Apps/Calendar/main/Source/CalendarApp.h
Apps/MusicPlayer/CMakeLists.txt
Apps/MusicPlayer/README.md
Apps/MusicPlayer/main/CMakeLists.txt
Apps/MusicPlayer/main/Source/MusicLibrary.cpp
Apps/MusicPlayer/main/Source/MusicPlayer.cpp
Apps/MusicPlayer/main/Source/MusicPlayer.h
Apps/MusicPlayer/main/Source/Playback.cpp
Apps/MusicPlayer/main/Source/main.cpp
Apps/MusicPlayer/manifest.properties
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Quick win
Do not accept a failed property result as an empty calendar.
A 207 response can contain <c:calendar-data/> with a failed DAV:propstat status. CalDAV uses per-property status results; HTTP success alone does not establish successful data retrieval. (rfc-editor.org)
This branch skips the empty element without checking its status. The parser returns success, so calendarProcessRequests replaces the retained agenda with an empty list and reports “Synced 0 upcoming events.”
Check the enclosing status, or reject empty calendar-data for this full-calendar request. Preserve the existing agenda on failure. Keep an empty multistatus valid for a successful query with no matches.
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Quick win
Reject output changes during active playback.
The dropdown remains enabled until the next 250 ms refresh. During that interval, this callback can select B after playback has captured A. Audio continues through A, but the volume slider controls B. Check playback activity in this callback and restore the existing selection when changes are not permitted. Allow output changes when playback is idle. (raw.githubusercontent.com)
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Quick win
Preserve a selection until playback acknowledges it.
If Next selects B while A is stopping, this timer can replace the selection with A before the worker starts B. Another Next then requests B again instead of C. Keep the requested selection separate from the active track, or skip reconciliation while a start or stop transition remains outstanding. Continue following currentTrackIndex for automatic advancement. (raw.githubusercontent.com)
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Quick win
Synchronize command consumption with cancellation resets.
If Stop arrives after Line 283 consumes a start, these stores erase Stop and playback starts anyway. The reverse ordering also fails: musicPlayerRequestStart publishes the start before setting stopRequested, so its trailing store can cancel the newly started track.
Publish and consume the command and its cancellation state under the same controlMutex transaction. Do not clear flags that belong to a newer command.
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Quick win
Preserve user commands when advancing automatically.
If the user presses Stop or selects another track after Line 310 checks the flags, this call replaces that action with nextIndex. Playback can restart after Stop or play the wrong track.
Queue automatic advance under controlMutex only if no newer command has arrived. Use a command generation or equivalent ownership check. Fixing the start-consumption race alone does not protect this path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calendar 0.2.1
A for now read-only Calendar app that syncs upcoming events from a CalDAV calendar collection.
Settings for the calendar URL, username, and password, saved with Tactility preferences.
Use authenticated HTTPS CalDAV REPORT requests with certificate validation.
Display events for the next 30 days.
Tested only on T-DECK Plus.
Summary by CodeRabbit