Skip to content

Add Recorder app with Material theme and fold-out player - #75

Merged
KenVanHoeylandt merged 6 commits into
TactilityProject:mainfrom
Shadowtrance:recorder-app
Nov 17, 2026
Merged

KenVanHoeylandt merged 6 commits into
TactilityProject:mainfrom
Shadowtrance:recorder-app

Conversation

@Shadowtrance

@Shadowtrance Shadowtrance commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Added an audio recorder for creating and playing back WAV recordings.
    • Browse recordings with their duration, file size, and modification date; select a recording to open playback controls.
    • Pause or stop playback, and delete recordings after confirmation.
    • Recordings are saved in the app’s data folder as 16 kHz, mono, 16-bit WAV files, with a five-minute limit.
  • Documentation
    • Added guidance on recorder controls, storage, and supported devices.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 16 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c925e79e-4f17-42ee-b685-1b9efed196a6
Commits

Reviewing files that changed from the base of the PR and between fdf3ac7 and 7e19b69.

Files ignored due to path filters: 21

  • Apps/EpubReader/images/read_view_paper.png is excluded by !**/*.png
  • Apps/EpubReader/images/read_view_t_deck.png is excluded by !**/*.png
  • Apps/EpubReader/images/shelf_view_paper.png is excluded by !**/*.png
  • Apps/EpubReader/images/shelf_view_t_deck.png is excluded by !**/*.png
  • Apps/Snake/images/easy.png is excluded by !**/*.png
  • Apps/Snake/images/hardhell.png is excluded by !**/*.png
  • Apps/Snake/images/medium.png is excluded by !**/*.png
  • Apps/Snake/images/selection.png is excluded by !**/*.png
  • Apps/TamaTac/images/screenshot-1.png is excluded by !**/*.png
  • Apps/TamaTac/images/screenshot-11.png is excluded by !**/*.png
  • Apps/TamaTac/images/screenshot-12.png is excluded by !**/*.png
  • Apps/TamaTac/images/screenshot-13.png is excluded by !**/*.png
  • Apps/TamaTac/images/screenshot-14.png is excluded by !**/*.png
  • Apps/TamaTac/images/screenshot-15.png is excluded by !**/*.png
  • Apps/TamaTac/images/screenshot-16.png is excluded by !**/*.png
  • Apps/TamaTac/images/screenshot-one.tactility.tamatac.png is excluded by !**/*.png
  • Apps/TwoEleven/images/3x3.png is excluded by !**/*.png
  • Apps/TwoEleven/images/4x4.png is excluded by !**/*.png
  • Apps/TwoEleven/images/5x5.png is excluded by !**/*.png
  • Apps/TwoEleven/images/6x6.png is excluded by !**/*.png
  • Apps/TwoEleven/images/selection.png is excluded by !**/*.png
Files selected for processing: 13

  • Apps/AudioRecorder/README.md
  • Apps/AudioRecorder/main/Source/AudioRecorder.cpp
  • Apps/AudioRecorder/main/Source/AudioRecorder.h
  • Apps/AudioRecorder/main/Source/RecorderService.cpp
  • Apps/AudioRecorder/manifest.properties
  • Apps/EpubReader/README.md
  • Apps/EpubReader/manifest.properties
  • Apps/Snake/README.md
  • Apps/Snake/manifest.properties
  • Apps/TamaTac/README.md
  • Apps/TamaTac/manifest.properties
  • Apps/TwoEleven/README.md
  • Apps/TwoEleven/manifest.properties
Walkthrough

The pull request adds an AudioRecorder app that records audio to WAV files, plays recordings, and lists files for selection and deletion. The interface tracks recording and playback state, and the audio task performs stream operations separately from LVGL updates. The app includes build configuration, a manifest, and documentation.

Merge Risk: Moderate · previous review fdf3a

The new Recorder app works in its main paths but can lose or damage recordings in edge cases. Starting two recordings within the same second can overwrite the first, and a failed save can still be reported as successful. Playback can drop audio when the output stream accepts only part of a chunk. Closing the app during an operation can stall shutdown. These issues should be fixed before merging.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Add Recorder app with Material theme and fold-out player" matches the main change. The changeset adds a new AudioRecorder app with a recordings list, WAV recording and playback, and a playe…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Add Recorder app with Material theme and fold-out player" matches the main change. The changeset adds a new AudioRecorder app with a recordings list, WAV recording and playback, and a player UI. The 'Material theme' part is not evident in the reviewed summaries, so that detail is only partly supported. The title is concise and specific enough for a teammate scanning history to understand the primary change.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 8

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8d96ff4b-fcfa-44d1-9bae-a878ee2b6c7e
Commits

Reviewing files that changed from the base of the PR and between 65b26ff and fdf3ac7.

Files ignored due to path filters: 6

  • Apps/AudioRecorder/icon.svg is excluded by !**/*.svg
  • Apps/AudioRecorder/icon_mono.svg is excluded by !**/*.svg
  • Apps/AudioRecorder/images/tab5-player.png is excluded by !**/*.png
  • Apps/AudioRecorder/images/tab5-recordings.png is excluded by !**/*.png
  • Apps/AudioRecorder/images/tdeck-player.png is excluded by !**/*.png
  • Apps/AudioRecorder/images/tdeck-recordings.png is excluded by !**/*.png
Files selected for processing: 8

  • Apps/AudioRecorder/CMakeLists.txt
  • Apps/AudioRecorder/README.md
  • Apps/AudioRecorder/main/CMakeLists.txt
  • Apps/AudioRecorder/main/Source/AudioRecorder.cpp
  • Apps/AudioRecorder/main/Source/AudioRecorder.h
  • Apps/AudioRecorder/main/Source/RecorderService.cpp
  • Apps/AudioRecorder/main/Source/main.cpp
  • Apps/AudioRecorder/manifest.properties

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

- Make the audio task handle atomic
- Publish recording success/failure and consume it in the poll timer
- Reserve unique .wav/.part paths with an _N suffix and O_EXCL
- Validate WAV finalization and discard failed or empty recordings
- Retry short audio writes and advance progress by accepted bytes only
- Honor shutdown before dispatch and inside record/playback loops
- Restore paused playback progress after rebuilding the inline player
The audio task now publishes RecordingResult and the finalized .wav path
together under pathMutex, and the poll timer reads and clears both under the
same lock. A queued playback can change activeFilepath without changing the
path that is selected for the completed recording.
@KenVanHoeylandt
KenVanHoeylandt merged commit c97234f into TactilityProject:main Nov 17, 2026
40 checks passed
@KenVanHoeylandt

Copy link
Copy Markdown
Contributor

Great work once again, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants