You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add Recorder app with Material theme and fold-out player - #75
The pull request adds an AudioRecorder app that records audio to WAV files, plays recordings, and lists files for selection and deletion. The interface tracks recording and playback state, and the audio task performs stream operations separately from LVGL updates. The app includes build configuration, a manifest, and documentation.
Merge Risk: Moderate · previous review fdf3a
The new Recorder app works in its main paths but can lose or damage recordings in edge cases. Starting two recordings within the same second can overwrite the first, and a failed save can still be reported as successful. Playback can drop audio when the output stream accepts only part of a chunk. Closing the app during an operation can stall shutdown. These issues should be fixed before merging.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "Add Recorder app with Material theme and fold-out player" matches the main change. The changeset adds a new AudioRecorder app with a recordings list, WAV recording and playback, and a playe…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "Add Recorder app with Material theme and fold-out player" matches the main change. The changeset adds a new AudioRecorder app with a recordings list, WAV recording and playback, and a player UI. The 'Material theme' part is not evident in the reviewed summaries, so that detail is only partly supported. The title is concise and specific enough for a teammate scanning history to understand the primary change.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
- Make the audio task handle atomic
- Publish recording success/failure and consume it in the poll timer
- Reserve unique .wav/.part paths with an _N suffix and O_EXCL
- Validate WAV finalization and discard failed or empty recordings
- Retry short audio writes and advance progress by accepted bytes only
- Honor shutdown before dispatch and inside record/playback loops
- Restore paused playback progress after rebuilding the inline player
The audio task now publishes RecordingResult and the finalized .wav path
together under pathMutex, and the poll timer reads and clears both under the
same lock. A queued playback can change activeFilepath without changing the
path that is selected for the completed recording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit