You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Move PSRAM request from DisplayApi to device.properties - #762
A driver shouldn't request an LVGL behaviour. It's a device-specific setting. DTS isn't the right place for it either, because it is only relevant for the LVGL subsystem that might not even exit.
Hence the setting is moved to Kconfig and determined by device.properties, processed by device.py
Summary by CodeRabbit
New Features
Added a global option to allocate LVGL draw buffers from external RAM, with per-device settings available for supported devices.
Enabled external RAM preference on additional devices.
Changes
Updated display memory guidance and allocation behavior. Display drivers no longer advertise an external-RAM preference; buffer allocation is controlled by configuration instead.
The changes add a Kconfig option for LVGL external RAM preference, defaulting to disabled. Device properties can set the option to true or false, and LVGL now uses that setting instead of display capabilities. Affected display drivers no longer advertise the removed capability. Multiple device properties enable the preference; one also sets the LVGL font size to 18. Three TODO entries were removed from the ideas document.
Merge Risk: Low · up to 1c648
The LVGL PSRAM preference now comes from device.properties instead of the display driver. Devices that use direct DMA from external-RAM buffers need the documented cache synchronization or the displayed pixels may be stale. Merge risk is low; document or verify the coherency requirement for esp-mosaico.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the main change: the PSRAM (external RAM) request for LVGL moves from DisplayApi to device.properties. The raw summary confirms this. Each device.properties gains lvgl.preferExternalRa…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: the PSRAM (external RAM) request for LVGL moves from DisplayApi to device.properties. The raw summary confirms this. Each device.properties gains lvgl.preferExternalRam, DISPLAY_CAPABILITY_PREFER_EXTERNAL_RAM is removed from the drivers and the enum, and device.py and Kconfig now carry the setting. The title is concise and specific to the primary change.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A driver shouldn't request an LVGL behaviour. It's a device-specific setting. DTS isn't the right place for it either, because it is only relevant for the LVGL subsystem that might not even exit.
Hence the setting is moved to
Kconfigand determined bydevice.properties, processed bydevice.pySummary by CodeRabbit
New Features
Changes