Skip to content

System bars in window manager, card-style Settings launcher, Files path bar and more - #761

Merged
KenVanHoeylandt merged 11 commits into
mainfrom
develop
Nov 18, 2026
Merged

KenVanHoeylandt merged 11 commits into
mainfrom
develop

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The root layout and system bars move from Tactility/ into lvgl-window-manager-module with a public API, so apps can use a page bar with a main action and previous/next page buttons. The Launcher and Files use it. The Settings launcher becomes a card list, Files gets a path bar, and font size, launcher sizing and spacing now derive from the display's dpi. The simulator renders each profile at the real resolution and dpi of the device.

System bars (lvgl-window-manager-module)

  • New <lvgl_window_manager/system_bars.h>. system_bars_configure() takes optional callbacks (layout resolver, alignment resolver, system menu, extra screen widgets). The layout code, the root layout builder and the swipe-down-for-menu logic moved out of Tactility/lvgl/SystemBars.* and Lvgl.cpp.
  • Apps get a page bar: system_bars_set_main_action() for one main action icon (hidden until an app sets it), system_bars_set_page_button_callbacks() and system_bars_set_page_buttons_visible() for the previous/next buttons. The page bar is below the apps in the split layout and at the bottom of the strip in the side layout. The window manager resets all of it when a window's widgets are deleted.
  • Side layout previous/next buttons are up/down arrows; split layout uses left/right arrows. The buttons are fixed-size with a centered icon, so the mono theme's thicker pressed/selected border doesn't resize them or move the icon.
  • Layout and alignment: landscape displays use the side layout by default (previously only aspect ratio 1.5 or more). A new Left/Right alignment setting in Appearance puts the strip on the right and right-aligns the page bar in the split layout. The setting is saved in launcher.properties.
  • The system menu swipe zone in the side layout is a physical 5 mm band at the top edge, expressed in dp. Paging swipes that start in it are left to the menu.
  • New exports: system_bars_* functions, system_bars_get_alignment(), system_bars_is_menu_swipe_zone_pressed(), lvgl_statusbar_set_side_right() and lvgl_page_indicator_set_vertical().

Launcher

  • Settings mode shows horizontal cards (icon left, name right) with a separate card layout in TileGrid: width based on the default font size, padding and icon-to-text margin scale with the UI spacing, equal spacing around the grid, rows centered vertically, and a selection ring drawn outside the card.
  • Settings icons are white glyphs without a background. All Settings app SVGs and the new Kernel and Simulator Settings icons are cropped to the glyph, and every card icon has the same size (the default font size).
  • Paging dots: a row below the grid in the split layout, a column next to the strip in the side layout (left or right following the alignment). The space they take is reserved on the opposite side too, so the grid stays centered.
  • Paging swipes are left/right in the split layout and up/down in the side layout.
  • App mode tile icons are now 2.5 × the default font size. The selection ring is 1 dp thicker.
  • The mode switch button is the system bar's main action.

Files

  • The toolbar shows a path bar between the close and overflow buttons: a chip per directory, the leftmost segments replaced by a non-selectable .. when the path is too long, and at least the current directory and its parent always visible. The current directory's name is ellipsized when still too wide. The "navigate up" button and the title are gone.
  • Keyboard flow: selecting a path segment moves the selection to the next segment up, and opening a directory selects its first entry, or the nearest path segment when the directory is empty.
  • Page buttons and dots follow the system bars, same as the Launcher. Swiping follows the layout.

Device properties and defaults

  • device.py derives the default font size from display.dpi (round(14 × dpi / 143), with the T-Deck as the reference) when lvgl.fontSize isn't set. generate-fonts.py uses the same derivation.
  • New optional launcher.iconSizeScale and launcher.iconSpacingScale (fractions, default 1) multiply the launcher icon size and spacing. lvgl.dpi is documented as only affecting LV_DPX() sizing.
  • Launcher tile gap lerps from 2 dp to 16 dp with lvgl.uiSpacing, with a minimum gap on all four sides of the grid.
  • device.py no longer removes cmake-build-linux when the platform changes.

Display drivers

  • gamma-curve = <2> on the T-Deck and T-Deck Plus, <0> on the T-Embed CC1101 Plus.
  • The ST7789 binding defaults gamma-curve to 0. The other display bindings still default to 1; changing them is tracked in ideas.md.

Simulator

  • Profiles render at the device's real resolution with the real dpi (lvgl_display_set_default_dpi()) and the device's default font size, so layouts match the device. Profiles have dpi, fontSize, launcherIconSizeScale and launcherIconSpacingScale.
  • The simulator built-in fallback font for LV_SYMBOL_* follows the profile font size.
  • Runtime override hooks in lvgl-module: default font size, launcher scales, display dpi.
  • 2 finger swipe to scroll

Icons

  • Added keyboard_arrow_down, keyboard_arrow_left and keyboard_arrow_right to the shared icon font (regenerated subset and codepoints).
  • The toolbar close button uses the shared icon font, so it scales with the font size. App Hub headers use the shared icons too, so their selection areas are round.

Other fixes

  • App Hub header: tabs no longer overflow the header because chip and widget margins are now counted.
  • Mesh chat: sender name colours use a better mixed hash and vary saturation and value, so fewer senders share a colour.

Summary by CodeRabbit

  • New Features

    • Launcher settings now support tile and card layouts, adjustable icon sizing and spacing, and left/right system-bar alignment.
    • System bars support side or split layouts, page controls, and navigation gestures; landscape screens use side layout by default.
    • The Files app now offers a clickable path bar and page navigation through system controls.
    • Added keyboard navigation icons and icons for additional settings apps.
    • Simulator trackpad-style scrolling now supports swipe navigation.
  • Improvements

    • Font sizing adapts to display DPI when no explicit size is configured.
    • Updated display and launcher defaults for supported devices, including display gamma settings.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • Resume reviews
  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The changes add runtime display DPI, font-size, and launcher-scale settings. They replace Tactility’s system-bars implementation with window-manager APIs and update launcher and Files navigation to use those APIs. The tile grid gains card styling, revised spacing, and side-layout indicators. Device configurations add display gamma values. Other edits update icon assets, documentation, and several targeted application and driver behaviors.

Merge Risk: Low · previous review e2d38

Remaining issues are narrow: the page-number label in the side layout may crowd the tile area, a USB mouse reconnected through many distinct device addresses can lose the top-edge menu swipe, and a simulator right-click during a wheel swipe can block wheel scrolling until a left click. Normal use is unaffected, so merging is reasonable with these noted as follow-ups.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names three real changes in the PR: system bars moved into the window manager, a card-style Settings launcher, and a Files path bar. The changeset covers all three, and it is broad. The main…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names three real changes in the PR: system bars moved into the window manager, a card-style Settings launcher, and a Files path bar. The changeset covers all three, and it is broad. The main change is the system bars move into lvgl-window-manager-module, which the title lists first. The title does not mention the many smaller changes such as font scaling, gamma defaults, or Mesh sender colors, which is acceptable for a title.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2214835f-95f0-4531-936e-c476ac1f9c16
Commits

Reviewing files that changed from the base of the PR and between 569b393 and e2d388f.

Files selected for processing: 2

  • Devices/waveshare-s3-touch-amoled-206/CMakeLists.txt
  • Devices/waveshare-s3-touch-amoled-206/source/lvgl_insets.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 10

Nitpick comments: 1

Tactility/Private/Tactility/app/files/View.h: 1

61-63: Trivial · Maintainability & Code Quality · Quick win

Use external-RAM containers for the path-bar state.

Both containers live with View, but ::std::vector and ::std::string use their standard allocators. Allocating View externally does not move these backing allocations into external RAM.

Use tt::std::vector for both containers and tt::std::string for the stored paths. Convert strings at API boundaries where needed.

As per coding guidelines, “Containers that live long use the tt::std replacements from TactilityKernel.”

Source: Coding guidelines

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3616d8eb-a770-4f59-9cd4-2789a8b1debb
Commits

Reviewing files that changed from the base of the PR and between 6142ddb and 61cc4b1.

Files ignored due to path filters: 23

  • Data/system/app_icon/tactility.appearance.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.audiosettings.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.btmanage.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.development.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.display.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.grovesettings.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.kernelsettings.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.kernelsettings_mono.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.keyboardsettings.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.languagesettings.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.ledstripsettings.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.locationsettings.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.meshsettings.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.power.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.simulator.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.simulator_mono.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.timedatesettings.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.touchcalibration.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.trackballsettings.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.usbsettings.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.vibrationsettings.svg is excluded by !**/*.svg
  • Data/system/app_icon/tactility.wifimanage.svg is excluded by !**/*.svg
  • Data/system/fonts/MaterialSymbolsRounded.ttf is excluded by !**/*.ttf
Files selected for processing: 66

  • .claude/rules/app-icons.md
  • .claude/rules/lvgl.md
  • Buildscripts/generate-fonts.py
  • Data/system/fonts/MaterialSymbolsRounded.codepoints
  • Devices/cl32-v02-v03/device.properties
  • Devices/cl32-v04/device.properties
  • Devices/espressif-esp32-s31-korvo-1/device.properties
  • Devices/lilygo-tdeck-plus/lilygo,tdeck-plus.dts
  • Devices/lilygo-tdeck/lilygo,tdeck.dts
  • Devices/lilygo-tembed-cc1101-plus/lilygo,tembed-cc1101-plus.dts
  • Devices/lilygo-tembed-cc1101/lilygo,tembed-cc1101.dts
  • Devices/lilygo-tlora-pager/device.properties
  • Devices/m5stack-tab5/device.properties
  • Devices/simulator/Source/SimulatorProfile.cpp
  • Devices/simulator/Source/SimulatorProfile.h
  • Devices/simulator/Source/module.cpp
  • Documentation/ideas.md
  • Drivers/gpio-encoder-module/source/gpio_encoder.cpp
  • Drivers/st7789-module/bindings/sitronix,st7789.yaml
  • Modules/lvgl-module/generate-icons.py
  • Modules/lvgl-module/include/lvgl/devices/display.h
  • Modules/lvgl-module/include/lvgl/icons/names.h
  • Modules/lvgl-module/include/lvgl/icons/shared.h
  • Modules/lvgl-module/include/lvgl/theme.h
  • Modules/lvgl-module/include/lvgl/widgets/page_indicator.h
  • Modules/lvgl-module/include/lvgl/widgets/statusbar.h
  • Modules/lvgl-module/include/lvgl/widgets/toolbar.h
  • Modules/lvgl-module/source/devices/display.cpp
  • Modules/lvgl-module/source/icon_names.c
  • Modules/lvgl-module/source/symbols.c
  • Modules/lvgl-module/source/theme.cpp
  • Modules/lvgl-module/source/widgets/page_indicator.cpp
  • Modules/lvgl-module/source/widgets/statusbar.cpp
  • Modules/lvgl-module/source/widgets/toolbar.cpp
  • Modules/lvgl-module/tests/source/svg_test.cpp
  • Modules/lvgl-window-manager-module/include/lvgl_window_manager/system_bars.h
  • Modules/lvgl-window-manager-module/source/module.cpp
  • Modules/lvgl-window-manager-module/source/system_bars.cpp
  • Modules/lvgl-window-manager-module/source/system_bars_internal.h
  • Modules/lvgl-window-manager-module/source/window_manager.cpp
  • Modules/mesh-meshtastic-module/source/meshtastic_backend.cpp
  • Tactility/Include/Tactility/settings/LauncherSettings.h
  • Tactility/Kconfig
  • Tactility/Private/Tactility/app/TileGrid.h
  • Tactility/Private/Tactility/app/files/View.h
  • Tactility/Private/Tactility/app/launcher/LauncherMode.h
  • Tactility/Private/Tactility/lvgl/FontSizes.h
  • Tactility/Private/Tactility/lvgl/SystemBars.h
  • Tactility/Source/app/TileGrid.cpp
  • Tactility/Source/app/appearancesettings/AppearanceSettings.cpp
  • Tactility/Source/app/apphub/AppHubApp.cpp
  • Tactility/Source/app/files/View.cpp
  • Tactility/Source/app/launcher/AppsMode.cpp
  • Tactility/Source/app/launcher/Launcher.cpp
  • Tactility/Source/app/launcher/SettingsMode.cpp
  • Tactility/Source/app/meshchat/MeshConversation.cpp
  • Tactility/Source/app/setup/Setup.cpp
  • Tactility/Source/app/touchcalibration/TouchCalibration.cpp
  • Tactility/Source/app/wificonnect/WifiConnect.cpp
  • Tactility/Source/lvgl/FontSizes.cpp
  • Tactility/Source/lvgl/Fonts.cpp
  • Tactility/Source/lvgl/Lvgl.cpp
  • Tactility/Source/lvgl/SystemBars.cpp
  • Tactility/Source/settings/LauncherSettings.cpp
  • Tactility/Tests/Source/SystemBarsLayoutTest.cpp
  • device.py
Files with no reviewable changes: 3

  • Devices/m5stack-tab5/device.properties
  • Tactility/Private/Tactility/lvgl/SystemBars.h
  • Tactility/Source/lvgl/SystemBars.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread Tactility/Source/app/files/View.cpp Resolved
Comment thread Tactility/Source/app/TileGrid.cpp Resolved
Comment thread Tactility/Source/app/TileGrid.cpp Resolved
Comment thread Tactility/Source/app/TileGrid.cpp Resolved

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f5950328-41bf-4b56-9a43-bbcfc83265c1
Commits

Reviewing files that changed from the base of the PR and between 61cc4b1 and 7ad0077.

Files selected for processing: 11

  • Devices/simulator/Source/SimulatorProfile.cpp
  • Modules/lvgl-window-manager-module/source/system_bars.cpp
  • Tactility/Private/Tactility/app/TileGrid.h
  • Tactility/Source/app/TileGrid.cpp
  • Tactility/Source/app/appearancesettings/AppearanceSettings.cpp
  • Tactility/Source/app/apphub/AppHubApp.cpp
  • Tactility/Source/app/apphubdetails/AppHubDetailsApp.cpp
  • Tactility/Source/app/files/View.cpp
  • Tactility/Source/lvgl/Fonts.cpp
  • Tactility/Source/lvgl/UsbHidInput.cpp
  • lv_conf.h
Files skipped from review as they are similar to previous changes: 1

  • Tactility/Source/app/files/View.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Comment thread Tactility/Source/lvgl/UsbHidInput.cpp Resolved

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 34958794-ef3c-490b-907a-f87246876fd6
Commits

Reviewing files that changed from the base of the PR and between 059aef1 and 569b393.

Files selected for processing: 5

  • Devices/simulator/Source/drivers/sdl_input.cpp
  • Modules/lvgl-window-manager-module/include/lvgl_window_manager/system_bars.h
  • Modules/lvgl-window-manager-module/source/module.cpp
  • Modules/lvgl-window-manager-module/source/system_bars.cpp
  • Tactility/Source/lvgl/UsbHidInput.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

@KenVanHoeylandt
KenVanHoeylandt merged commit 5310658 into main Nov 18, 2026
84 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the develop branch November 18, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant