You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
System bars in window manager, card-style Settings launcher, Files path bar and more - #761
The root layout and system bars move from Tactility/ into lvgl-window-manager-module with a public API, so apps can use a page bar with a main action and previous/next page buttons. The Launcher and Files use it. The Settings launcher becomes a card list, Files gets a path bar, and font size, launcher sizing and spacing now derive from the display's dpi. The simulator renders each profile at the real resolution and dpi of the device.
System bars (lvgl-window-manager-module)
New <lvgl_window_manager/system_bars.h>. system_bars_configure() takes optional callbacks (layout resolver, alignment resolver, system menu, extra screen widgets). The layout code, the root layout builder and the swipe-down-for-menu logic moved out of Tactility/lvgl/SystemBars.* and Lvgl.cpp.
Apps get a page bar: system_bars_set_main_action() for one main action icon (hidden until an app sets it), system_bars_set_page_button_callbacks() and system_bars_set_page_buttons_visible() for the previous/next buttons. The page bar is below the apps in the split layout and at the bottom of the strip in the side layout. The window manager resets all of it when a window's widgets are deleted.
Side layout previous/next buttons are up/down arrows; split layout uses left/right arrows. The buttons are fixed-size with a centered icon, so the mono theme's thicker pressed/selected border doesn't resize them or move the icon.
Layout and alignment: landscape displays use the side layout by default (previously only aspect ratio 1.5 or more). A new Left/Right alignment setting in Appearance puts the strip on the right and right-aligns the page bar in the split layout. The setting is saved in launcher.properties.
The system menu swipe zone in the side layout is a physical 5 mm band at the top edge, expressed in dp. Paging swipes that start in it are left to the menu.
New exports: system_bars_* functions, system_bars_get_alignment(), system_bars_is_menu_swipe_zone_pressed(), lvgl_statusbar_set_side_right() and lvgl_page_indicator_set_vertical().
Launcher
Settings mode shows horizontal cards (icon left, name right) with a separate card layout in TileGrid: width based on the default font size, padding and icon-to-text margin scale with the UI spacing, equal spacing around the grid, rows centered vertically, and a selection ring drawn outside the card.
Settings icons are white glyphs without a background. All Settings app SVGs and the new Kernel and Simulator Settings icons are cropped to the glyph, and every card icon has the same size (the default font size).
Paging dots: a row below the grid in the split layout, a column next to the strip in the side layout (left or right following the alignment). The space they take is reserved on the opposite side too, so the grid stays centered.
Paging swipes are left/right in the split layout and up/down in the side layout.
App mode tile icons are now 2.5 × the default font size. The selection ring is 1 dp thicker.
The mode switch button is the system bar's main action.
Files
The toolbar shows a path bar between the close and overflow buttons: a chip per directory, the leftmost segments replaced by a non-selectable .. when the path is too long, and at least the current directory and its parent always visible. The current directory's name is ellipsized when still too wide. The "navigate up" button and the title are gone.
Keyboard flow: selecting a path segment moves the selection to the next segment up, and opening a directory selects its first entry, or the nearest path segment when the directory is empty.
Page buttons and dots follow the system bars, same as the Launcher. Swiping follows the layout.
Device properties and defaults
device.py derives the default font size from display.dpi (round(14 × dpi / 143), with the T-Deck as the reference) when lvgl.fontSize isn't set. generate-fonts.py uses the same derivation.
New optional launcher.iconSizeScale and launcher.iconSpacingScale (fractions, default 1) multiply the launcher icon size and spacing. lvgl.dpi is documented as only affecting LV_DPX() sizing.
Launcher tile gap lerps from 2 dp to 16 dp with lvgl.uiSpacing, with a minimum gap on all four sides of the grid.
device.py no longer removes cmake-build-linux when the platform changes.
Display drivers
gamma-curve = <2> on the T-Deck and T-Deck Plus, <0> on the T-Embed CC1101 Plus.
The ST7789 binding defaults gamma-curve to 0. The other display bindings still default to 1; changing them is tracked in ideas.md.
Simulator
Profiles render at the device's real resolution with the real dpi (lvgl_display_set_default_dpi()) and the device's default font size, so layouts match the device. Profiles have dpi, fontSize, launcherIconSizeScale and launcherIconSpacingScale.
The simulator built-in fallback font for LV_SYMBOL_* follows the profile font size.
Runtime override hooks in lvgl-module: default font size, launcher scales, display dpi.
2 finger swipe to scroll
Icons
Added keyboard_arrow_down, keyboard_arrow_left and keyboard_arrow_right to the shared icon font (regenerated subset and codepoints).
The toolbar close button uses the shared icon font, so it scales with the font size. App Hub headers use the shared icons too, so their selection areas are round.
Other fixes
App Hub header: tabs no longer overflow the header because chip and widget margins are now counted.
Mesh chat: sender name colours use a better mixed hash and vary saturation and value, so fewer senders share a colour.
Summary by CodeRabbit
New Features
Launcher settings now support tile and card layouts, adjustable icon sizing and spacing, and left/right system-bar alignment.
System bars support side or split layouts, page controls, and navigation gestures; landscape screens use side layout by default.
The Files app now offers a clickable path bar and page navigation through system controls.
Added keyboard navigation icons and icons for additional settings apps.
Simulator trackpad-style scrolling now supports swipe navigation.
Improvements
Font sizing adapts to display DPI when no explicit size is configured.
Updated display and launcher defaults for supported devices, including display gamma settings.
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
No actionable comments were generated in the recent review.
Walkthrough
The changes add runtime display DPI, font-size, and launcher-scale settings. They replace Tactility’s system-bars implementation with window-manager APIs and update launcher and Files navigation to use those APIs. The tile grid gains card styling, revised spacing, and side-layout indicators. Device configurations add display gamma values. Other edits update icon assets, documentation, and several targeted application and driver behaviors.
Merge Risk: Low · previous review e2d38
Remaining issues are narrow: the page-number label in the side layout may crowd the tile area, a USB mouse reconnected through many distinct device addresses can lose the top-edge menu swipe, and a simulator right-click during a wheel swipe can block wheel scrolling until a left click. Normal use is unaffected, so merging is reasonable with these noted as follow-ups.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names three real changes in the PR: system bars moved into the window manager, a card-style Settings launcher, and a Files path bar. The changeset covers all three, and it is broad. The main…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names three real changes in the PR: system bars moved into the window manager, a card-style Settings launcher, and a Files path bar. The changeset covers all three, and it is broad. The main change is the system bars move into lvgl-window-manager-module, which the title lists first. The title does not mention the many smaller changes such as font scaling, gamma defaults, or Mesh sender colors, which is acceptable for a title.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.
Use external-RAM containers for the path-bar state.
Both containers live with View, but ::std::vector and ::std::string use their standard allocators. Allocating View externally does not move these backing allocations into external RAM.
Use tt::std::vector for both containers and tt::std::string for the stored paths. Convert strings at API boundaries where needed.
As per coding guidelines, “Containers that live long use the tt::std replacements from TactilityKernel.”
Source: Coding guidelines
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 3616d8eb-a770-4f59-9cd4-2789a8b1debb
Commits
Reviewing files that changed from the base of the PR and between 6142ddb and 61cc4b1.
Files ignored due to path filters: 23
Data/system/app_icon/tactility.appearance.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.audiosettings.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.btmanage.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.development.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.display.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.grovesettings.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.kernelsettings.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.kernelsettings_mono.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.keyboardsettings.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.languagesettings.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.ledstripsettings.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.locationsettings.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.meshsettings.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.power.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.simulator.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.simulator_mono.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.timedatesettings.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.touchcalibration.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.trackballsettings.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.usbsettings.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.vibrationsettings.svg is excluded by !**/*.svg
Data/system/app_icon/tactility.wifimanage.svg is excluded by !**/*.svg
Data/system/fonts/MaterialSymbolsRounded.ttf is excluded by !**/*.ttf
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
Files skipped from review as they are similar to previous changes: 1
Tactility/Source/app/files/View.cpp
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The root layout and system bars move from
Tactility/intolvgl-window-manager-modulewith a public API, so apps can use a page bar with a main action and previous/next page buttons. The Launcher and Files use it. The Settings launcher becomes a card list, Files gets a path bar, and font size, launcher sizing and spacing now derive from the display's dpi. The simulator renders each profile at the real resolution and dpi of the device.System bars (
lvgl-window-manager-module)<lvgl_window_manager/system_bars.h>.system_bars_configure()takes optional callbacks (layout resolver, alignment resolver, system menu, extra screen widgets). The layout code, the root layout builder and the swipe-down-for-menu logic moved out ofTactility/lvgl/SystemBars.*andLvgl.cpp.system_bars_set_main_action()for one main action icon (hidden until an app sets it),system_bars_set_page_button_callbacks()andsystem_bars_set_page_buttons_visible()for the previous/next buttons. The page bar is below the apps in the split layout and at the bottom of the strip in the side layout. The window manager resets all of it when a window's widgets are deleted.launcher.properties.system_bars_*functions,system_bars_get_alignment(),system_bars_is_menu_swipe_zone_pressed(),lvgl_statusbar_set_side_right()andlvgl_page_indicator_set_vertical().Launcher
TileGrid: width based on the default font size, padding and icon-to-text margin scale with the UI spacing, equal spacing around the grid, rows centered vertically, and a selection ring drawn outside the card.Files
..when the path is too long, and at least the current directory and its parent always visible. The current directory's name is ellipsized when still too wide. The "navigate up" button and the title are gone.Device properties and defaults
device.pyderives the default font size fromdisplay.dpi(round(14 × dpi / 143), with the T-Deck as the reference) whenlvgl.fontSizeisn't set.generate-fonts.pyuses the same derivation.launcher.iconSizeScaleandlauncher.iconSpacingScale(fractions, default 1) multiply the launcher icon size and spacing.lvgl.dpiis documented as only affectingLV_DPX()sizing.lvgl.uiSpacing, with a minimum gap on all four sides of the grid.device.pyno longer removescmake-build-linuxwhen the platform changes.Display drivers
gamma-curve = <2>on the T-Deck and T-Deck Plus,<0>on the T-Embed CC1101 Plus.gamma-curveto 0. The other display bindings still default to 1; changing them is tracked inideas.md.Simulator
lvgl_display_set_default_dpi()) and the device's default font size, so layouts match the device. Profiles havedpi,fontSize,launcherIconSizeScaleandlauncherIconSpacingScale.LV_SYMBOL_*follows the profile font size.lvgl-module: default font size, launcher scales, display dpi.Icons
keyboard_arrow_down,keyboard_arrow_leftandkeyboard_arrow_rightto the shared icon font (regenerated subset and codepoints).Other fixes
Summary by CodeRabbit
New Features
Improvements