test(deploy): pass the large path list on stdin, not in the environment - #41
Merged
Merged
Conversation
Linux caps a single environment string at 128 KB, so the 190 KB list the pipe-buffer test builds made proc_open fail with "Argument list too long" on CI. macOS has no such cap, which is why it passed locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#40's new test put a 190 KB path list in an environment variable. Linux caps a single environment string at 128 KB, so on CI
proc_openfailed with "Argument list too long" andmainwent red (the deploy was skipped). macOS has no such cap, so it passed locally. The list now goes in on stdin. The test still runs the script's ownchanged()underset -euo pipefailagainst a list larger than a pipe buffer.