Repository navigation
Conversation
The examples presented an explicit null timezone as the default, while it disables the %sylius_grid.timezone% conversion, and documented the default format as Y:m:d H:i:s instead of Y-m-d H:i:s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SVillette
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to Sylius/SyliusGridBundle#506.
DateTimeField::create('birthday', 'Y:m:d H:i:s', null)andtimezone: nullas the defaults. An explicitnullactually disables the%sylius_grid.timezone%conversion; the examples now show an override instead, and thetimezoneoption documentsnullas the way to opt out.Y-m-d H:i:s, notY:m:d H:i:s.setOptions()hint passed the string'null'as timezone, which throws inDateTimeZone, and said the options would be unset while they fall back to their defaults.The PHP builder examples only behave as documented once Sylius/SyliusGridBundle#506 is
released, so this may be worth merging alongside it.
🤖 Generated with Claude Code