Skip to content

ci: trigger pipeline on main, not the nonexistent master branch - #9

Merged
mattmattox merged 2 commits into
mainfrom
fix/taskforge-2814-24159
Oct 4, 2026
Merged

mattmattox merged 2 commits into
mainfrom
fix/taskforge-2814-24159

Conversation

@mattmattox

Copy link
Copy Markdown
Contributor

Summary

The default branch is main, but .github/workflows/pipeline.yml triggered only on push to master, a branch that does not exist. Test, Build and Publish have never run, and no image or chart has been published from main (gh run list shows only Dependabot runs).

  • Trigger on push to main.
  • Run Test on pull requests to main. Build (and Publish, which needs Build) are gated to push on main, because they push the Docker image and the helm chart.
  • Docker Hub login now uses the org-wide DOCKER_USERNAME / DOCKER_PASSWORD secrets (visibility ALL, also used by 53 sibling workflows). DOCKERHUB_USERNAME / DOCKERHUB_TOKEN exist in neither this repo nor the org, so the first real Build would have failed at login.

Credentials checked

  • CHART_APP_PRIVATE_KEY (org secret, SELECTED) and CHART_APP_CLIENT_ID (org variable, SELECTED) both include RancherResourceScanner.
  • DOCKER_USERNAME / DOCKER_PASSWORD are org secrets with visibility ALL.

Heads-up

The merge itself pushes to main, so it runs the full pipeline for the first time: it pushes supporttools/rancherresourcescanner:v<run> and :latest, and commits a chart to SupportTools/helm-chart.

Validation

actionlint v1.7.12 reports nothing new. Every finding it prints predates this change:

  • the custom runner label self-hosted-linux
  • stale metadata for create-github-app-token@v3 (client-id is a valid v3 input per upstream action.yml)
  • SC2046 on the unquoted $(date) build-arg

TaskForge: taskforge-2814 (spawned from taskforge-2674 / #8)

Fixes: taskforge-2814

The default branch is main but pipeline.yml triggered only on push to
master, so Test, Build and Publish never ran and nothing was published
from main. Trigger on push to main; run Test on pull requests to main
and gate Build (and so Publish) to push on main. Switch the Docker Hub
login to the org-wide DOCKER_USERNAME/DOCKER_PASSWORD secrets: the
DOCKERHUB_USERNAME/DOCKERHUB_TOKEN names exist in neither the repo
nor the org, so the first real Build would have failed at login.

Refs: taskforge-2814
Publish -> 'Package Helm chart' runs envsubst over Chart.yaml.template and
values.yaml.template, which did not exist; the first main push would fail
with 'No such file or directory' after Build already pushed the image.
Add both templates (version/appVersion from CHART_VERSION/APP_VERSION,
image tag from IMAGE_TAG) and point image.repository at
supporttools/rancherresourcescanner instead of the scaffold's nginx.

Verified locally: envsubst + helm lint + helm package with v42 renders
image supporttools/rancherresourcescanner:v42.

Task: #24159
@mattmattox
mattmattox merged commit e28d8a8 into main Oct 4, 2026
3 checks passed
@mattmattox
mattmattox deleted the fix/taskforge-2814-24159 branch October 4, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant