Repository navigation
ci: trigger pipeline on main, not the nonexistent master branch - #9
Merged
Merged
Conversation
The default branch is main but pipeline.yml triggered only on push to master, so Test, Build and Publish never ran and nothing was published from main. Trigger on push to main; run Test on pull requests to main and gate Build (and so Publish) to push on main. Switch the Docker Hub login to the org-wide DOCKER_USERNAME/DOCKER_PASSWORD secrets: the DOCKERHUB_USERNAME/DOCKERHUB_TOKEN names exist in neither the repo nor the org, so the first real Build would have failed at login. Refs: taskforge-2814
Publish -> 'Package Helm chart' runs envsubst over Chart.yaml.template and values.yaml.template, which did not exist; the first main push would fail with 'No such file or directory' after Build already pushed the image. Add both templates (version/appVersion from CHART_VERSION/APP_VERSION, image tag from IMAGE_TAG) and point image.repository at supporttools/rancherresourcescanner instead of the scaffold's nginx. Verified locally: envsubst + helm lint + helm package with v42 renders image supporttools/rancherresourcescanner:v42. Task: #24159
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default branch is
main, but.github/workflows/pipeline.ymltriggered only on push tomaster, a branch that does not exist. Test, Build and Publish have never run, and no image or chart has been published frommain(gh run listshows only Dependabot runs).main.main. Build (and Publish, which needs Build) are gated to push onmain, because they push the Docker image and the helm chart.DOCKER_USERNAME/DOCKER_PASSWORDsecrets (visibility ALL, also used by 53 sibling workflows).DOCKERHUB_USERNAME/DOCKERHUB_TOKENexist in neither this repo nor the org, so the first real Build would have failed at login.Credentials checked
CHART_APP_PRIVATE_KEY(org secret, SELECTED) andCHART_APP_CLIENT_ID(org variable, SELECTED) both include RancherResourceScanner.DOCKER_USERNAME/DOCKER_PASSWORDare org secrets with visibility ALL.Heads-up
The merge itself pushes to
main, so it runs the full pipeline for the first time: it pushessupporttools/rancherresourcescanner:v<run>and:latest, and commits a chart to SupportTools/helm-chart.Validation
actionlint v1.7.12 reports nothing new. Every finding it prints predates this change:
self-hosted-linuxcreate-github-app-token@v3(client-idis a valid v3 input per upstream action.yml)$(date)build-argTaskForge: taskforge-2814 (spawned from taskforge-2674 / #8)
Fixes: taskforge-2814