Repository navigation
test(goclusterfs): keep a crashed node's locks through the test replay - #91
Merged
Merged
Conversation
remountAndReplay replayed the crashed node's journal as a new node without taking over the crashed node's lock claims, so its replay and the tests after it waited 15s for those claims to go stale. It now adopts them for the replay and releases them after, as mount does for a dead node. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only.
remountAndReplayreplayed a crashed node's journal as a new node, but didn't take over the crashed node's lock claims first. So the replay and the test after it waited 15s for those claims to go stale. It now adopts them for the replay and releases them after, as mount does for a dead node.Each test node keeps its slot in the last byte of its UUID, so the helper finds the crashed node's slot from the owner recorded in its journal.
On .68, all 86 goclusterfs tests pass, and the package run drops from 132s to 85s. The remaining slow tests wait on stuck locks on purpose (30s), plus one fsck test at 7s.
Under #90 a claim never goes stale once an owner view is installed. Test lock managers don't install one, so these tests didn't hang under #90 either.
🤖 Generated with Claude Code