Repository navigation
fix(lock): renew held and adopted lock slots in the background - #83
Closed
mattmattox wants to merge 1 commit into
Closed
mattmattox wants to merge 1 commit into
mattmattox wants to merge 1 commit into
Conversation
A node renewed a claim only when another operation joined the hold, so a single operation or a journal replay that ran past 15s let its claims go stale and another node could take a lock still in use. Mount now starts a renewer that rewrites held records and adopted slots once they are 2.5s old. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of the three lock follow-ups: (a) lease renewal, (b) take over a lock only after its holder is released, (c) a pre-write ownership check.
Before this, a node renewed a claim only when another operation joined the hold. So one operation, or a journal replay, that ran past 15s let its claims go stale, and another node could take a lock that was still in use.
EIO. A hold that a goroutine leaks stays held until unmount.🤖 Generated with Claude Code