Repository navigation
fix(journal): replay a record only while other nodes have not changed what it touches - #80
Merged
Merged
Conversation
…eration left it A peer can take a dead node's locks before replaying its journal, so a record must not undo or repeat changes other nodes made since. InodeCreate, InodeDelete, DirRemoveEntry and ExtentAdd now log generations and replay checks them; DirAddEntry replays only with its inode's create. ExtentFree frees everything past the logged size, which removes the 256-extent cap. Root unlink and rmdir now share the subdirectory path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ashes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Subdirectory rmdir freed an inode only at link count 1, but directories start at 2, so their inodes leaked. Root rmdir now shares this path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A peer takes a dead node's locks after 15 s, without waiting for the dead node's journal to be replayed. Each replayed record must therefore be safe on its own, whatever happened after the crash. When a record finds what it touches changed since it was logged, replay now skips the record. The worst case is then a leak, not freeing or remapping another node's data.
Within one transaction, a record also accepts the generation that the replay itself wrote. For example, an unlink's ExtentFree writes the inode, and its InodeDelete still applies.
Audit
MetaGeneration;FreeIfchecks it under the inode lockClaimSlotIfclaims only if unchangedFolded-in follow-ups from #78
Residual gaps
Results at 86471d3
-short130/0.🤖 Generated with Claude Code