Repository navigation
fix(cache): stop serving stale inodes after cross-node inode reuse - #7
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…test The container healthcheck lists the mount every 2s, which can cache the new file's pre-write size in the reader's kernel for up to 1s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mattmattox
added a commit
that referenced
this pull request
Oct 24, 2026
mattmattox
added a commit
that referenced
this pull request
Oct 24, 2026
…elog, and templates (#9) * docs: add security policy, contributing guide, code of conduct, changelog, and templates Adds the community files GitHub expects for a public release: SECURITY.md (GitHub private vulnerability reporting, main only), CONTRIBUTING.md, CODE_OF_CONDUCT.md (Contributor Covenant 2.1), CHANGELOG.md with an Unreleased section, issue templates, and a pull request template. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: correct build, CI, and changelog claims in community files Write CONTRIBUTING against main after the CI gates PR: make build also builds goclusterfs-fsck, and CI adds golangci-lint, govulncheck, a go mod tidy check, and race/coverage unit tests. In the changelog, mark SFB, snapshots/clones, and fsck as experimental with their known issues, say file writes skip the distributed locks, and narrow the concurrency fix to create/mkdir lock ordering. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(changelog): add upgrade notes for mixed-version clusters Older binaries zero an inode's generations on free and its extent-tree generation on rewrite, so all nodes must be upgraded together. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(changelog): add CI gates, prototype removal, stale-inode and journal fixes Cover PRs #5, #6, #7 and #10, which merged to main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Freeing an inode reset its generation counters, so when a new file reused the inode number, another node's cached inode and extent mappings still passed validation. Reads came back truncated or from the old block. This caused the VM suite's Broadcast Bidirectional and Concurrent Directory Ops failures, and the Broadcast Bidirectional Docker flake seen on #5.
The on-disk format is unchanged. Freed slots now keep their generation bytes, and older binaries and fsck ignore them.
I didn't set go-fuse
StableAttr.Gen. go-fuse v2.9.0 gives the kernel unique node IDs, so the kernel never sees an inode number reused.Tested on the shared test host: unit,
-shortintegration, Docker (40 pass, 1 skip) and VM (45 pass). The new tests fail without the fix.Not fixed here: ordinary writes never bump
DataGeneration, so the extent cache can still go stale after truncate or CoW.🤖 Generated with Claude Code