Repository navigation
fix(gfsctl): hide the whole token and cap response size - #63
Merged
Merged
Conversation
From the review of #56: - config show printed the token's first and last 4 characters, most of a short token. It now prints "set (N chars)". - The client read whole responses into memory; it now stops at 16 MB. - The README says to tunnel over SSH or use a TLS proxy for a remote mount. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shepherd's non-blocking notes from #56:
gfsctl config showprinted the token's first and last 4 characters, which is most of a short token. It now printsset (N chars).Tests:
config shownever prints any part of the token, and an oversized response is refused. The gfsctl tests pass with-race, and lint reports 0 issues.🤖 Generated with Claude Code