Skip to content

fix(gfsctl): hide the whole token and cap response size - #63

Merged
mattmattox merged 1 commit into
mainfrom
claude/gfsctl-hardening
Nov 10, 2026
Merged

mattmattox merged 1 commit into
mainfrom
claude/gfsctl-hardening

Conversation

@mattmattox

Copy link
Copy Markdown
Contributor

The shepherd's non-blocking notes from #56:

  • gfsctl config show printed the token's first and last 4 characters, which is most of a short token. It now prints set (N chars).
  • The client read whole responses into memory. It now stops at 16 MB, so a misbehaving server can't make gfsctl buffer without bound.
  • The README's gfsctl section says to tunnel over SSH or use a TLS proxy for a remote mount. feat(api): add snapshot, clone and admin write endpoints #57 adds the same note to DEPLOYMENT.md and API-CONFIG.md; it isn't repeated here, to avoid a conflict.

Tests: config show never prints any part of the token, and an oversized response is refused. The gfsctl tests pass with -race, and lint reports 0 issues.

🤖 Generated with Claude Code

From the review of #56:
- config show printed the token's first and last 4 characters, most of a
  short token. It now prints "set (N chars)".
- The client read whole responses into memory; it now stops at 16 MB.
- The README says to tunnel over SSH or use a TLS proxy for a remote mount.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mattmattox
mattmattox merged commit c5bd664 into main Nov 10, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant