Repository navigation
test: read concurrent creates back from the other node - #62
Merged
Merged
Conversation
Since #45 an interrupted FUSE create finishes instead of failing with EIO, so TestMultiNodeConcurrentCreatesDoNotCollide no longer needs its EIO retry. It now also checks that each node reads every file the other node created, with the right content. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mattmattox
added a commit
that referenced
this pull request
Nov 13, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #45, an interrupted FUSE create finishes instead of failing with EIO, so
TestMultiNodeConcurrentCreatesDoNotCollidedrops its EIO retry. It now also checks that each node reads every file the other node created, with the right content. It polls for up to 15s first, since that's the cache window.On .68 the readback passed 50 of 50 runs: 20 short and 5 full (150 files per node) on main, and 20 short and 5 full on top of #59 with broadcast live.
Merge order: the test used to skip the readback because concurrent directory updates can still lose an entry until #29 confirms lock claims. .68 never hit that race, but CI's slower disks widen it. Merge this after #29, or expect an occasional "node N cannot read ... files" failure until #29 lands; that failure would be the #29 bug, not this test.
🤖 Generated with Claude Code