Repository navigation
test: give each integration node its own API port - #60
Merged
Merged
Conversation
Every test node started the API on the default 127.0.0.1:8080. Only one mount at a time could bind it, and on .68 an unrelated service holds it, so a -short run logged about 150 "Failed to start API server" lines. Each node now gets a free loopback port next to its broadcast ports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mattmattox
force-pushed
the
claude/test-node-api-ports
branch
from
November 12, 2026 07:10
07ba033 to
bc41e2e
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #59; retarget to main once #59 merges.
Every integration node started the API on the default
127.0.0.1:8080. Only one mount at a time could bind it, and on .68 an unrelated service holds it, so a-shortrun logged about 150Failed to start API serverlines. Each node now gets a free loopback port next to its broadcast ports (from #59), andfreeLoopbackAddrmoves into the shared helpers.No new "fail loudly" check is needed in the harness: since #59, a mount that cannot start broadcast exits, so a node can no longer run without it silently. Tests that pass
-broadcast=falseopt out explicitly.On .68 (
-short, #59 head vs this branch):Three tests swung by 10–16s in both directions between the runs (
TestMultiNodeConcurrentCreatesDoNotCollide+15s,TestMultiNodeConcurrentSameFileWrites3Nodes−16s,TestConcurrentPwritesToFallocatedBlock+10s). That's the intermittent 15s stale-lock reclaim described in #59, landing on a different test each run.Docker and VM need no change: each node there has its own network namespace, so the default ports do not collide. VMs use QEMU user networking and cannot reach each other at all, so broadcast has no peers there.
🤖 Generated with Claude Code