Skip to content

test: give each integration node its own API port - #60

Merged
mattmattox merged 3 commits into
mainfrom
claude/test-node-api-ports
Nov 12, 2026
Merged

mattmattox merged 3 commits into
mainfrom
claude/test-node-api-ports

Conversation

@mattmattox

Copy link
Copy Markdown
Contributor

Stacked on #59; retarget to main once #59 merges.

Every integration node started the API on the default 127.0.0.1:8080. Only one mount at a time could bind it, and on .68 an unrelated service holds it, so a -short run logged about 150 Failed to start API server lines. Each node now gets a free loopback port next to its broadcast ports (from #59), and freeLoopbackAddr moves into the shared helpers.

No new "fail loudly" check is needed in the harness: since #59, a mount that cannot start broadcast exits, so a node can no longer run without it silently. Tests that pass -broadcast=false opt out explicitly.

On .68 (-short, #59 head vs this branch):

  • API start failures: 155 → 0 (158 API servers listening).
  • Broadcast: 0 start failures on both.
  • Results: 101 passed, 0 failed on both.
  • Test time: 195s → 204s, well under the 8-minute limit.

Three tests swung by 10–16s in both directions between the runs (TestMultiNodeConcurrentCreatesDoNotCollide +15s, TestMultiNodeConcurrentSameFileWrites3Nodes −16s, TestConcurrentPwritesToFallocatedBlock +10s). That's the intermittent 15s stale-lock reclaim described in #59, landing on a different test each run.

Docker and VM need no change: each node there has its own network namespace, so the default ports do not collide. VMs use QEMU user networking and cannot reach each other at all, so broadcast has no peers there.

🤖 Generated with Claude Code

mattmattox and others added 2 commits November 12, 2026 00:52
Every test node started the API on the default 127.0.0.1:8080. Only one
mount at a time could bind it, and on .68 an unrelated service holds it,
so a -short run logged about 150 "Failed to start API server" lines. Each
node now gets a free loopback port next to its broadcast ports.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mattmattox
mattmattox force-pushed the claude/test-node-api-ports branch from 07ba033 to bc41e2e Compare November 12, 2026 07:10
@mattmattox
mattmattox changed the base branch from claude/fix-broadcast-ports to main November 12, 2026 07:11
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mattmattox
mattmattox merged commit 2856eeb into main Nov 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant