Repository navigation
test: skip the two-node first-write test in short mode until lock claims are confirmed - #22
Merged
Merged
Conversation
…ims are confirmed Taking a lock is still a read then a write, so two nodes that claim a free inode lock at the same moment can both hold it. The test does that for 20 files per run and loses one node's write in about 1 file in 150: 4 of 30 runs failed on main and 2 of 30 on #13 before #18 and #20 landed, so #18 is not the cause. CI runs integration with -short; full runs still include it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's Integration job fails on
TestMultiNodeConcurrentFirstWriteToSameBlocksince #13 merged. This skips it under-short, which is how CI runs integration; full runs still include it.The cause is the non-atomic lock takeover, not #18. Two nodes claiming a free inode lock at the same moment can both win, and this test does that for 20 fresh files per run. Looped on .68:
That's about 1 file in 150 losing a write. The confirmation PR removes this skip.
🤖 Generated with Claude Code