Repository navigation
fix(node): take back this host's slot when it goes stale between scans - #21
Merged
Merged
Conversation
Register checks this host's failed slots, then waits on its live-looking slots from other PID namespaces, then takes the first empty or failed slot. A slot that crossed the staleness threshold between the first scan and the wait was neither claimed nor watched, so Register took an empty slot and left the old journal to failure detection 20s later. TestRegisterTakesOtherPIDNamespaceSlotOnceStale hit this in CI. Register now rechecks every slot for this host's failed ones after the wait. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestRegisterTakesOtherPIDNamespaceSlotOnceStalefailed in #13's CI (Register took slot 0, want slot 2, after 122 ms). This was a real race inRegister, added in #15.Registerchecks this host's failed slots, then waits on live-looking slots from other PID namespaces, then takes the first empty or failed slot. A slot that crossed the 10 s staleness threshold between the first scan and the wait was neither claimed nor watched.Registerthen took an empty slot and left the old journal to failure detection about 20 s later. A restarted container whose old heartbeat expires in that window would hit it.Registernow rechecks every slot for this host's failed ones after the wait.Tests on .66, all with
-race:TestRegisterTakesOwnSlotThatGoesStaleWhileWaiting: fails 3/3 without the fix and passes 20/20 with it.TestRegisterTakesOtherPIDNamespaceSlotOnceStale: passes 200/200.🤖 Generated with Claude Code