Repository navigation
test(soak): model rename now that the filesystem supports it - #187
Merged
Merged
Conversation
Renames move a lane's files, links and directories, replace its other entries, or fail with the errno rename(2) gives. The driver also checks a symlink in its directory's listing instead of reading through it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The soak driver still expected every rename to fail, so on today's main the first successful rename failed the run. This models rename as main implements it. Renames are now 6 of the 101 op weights, up from 2 of 97.
renameErrnoand the kernel's checks.Tested on .66: a soak of main 7c31ff8 plus #185 and this branch ran 873 ops, 56 of them renames. Every result matched the model: 43 succeeded, 15 ENOENT, 3 EISDIR, 1 ENOTDIR, 1 EINVAL and 1 ENOTEMPTY. I stopped it to restart on main with #186. The 2h soak for #185 now uses this branch too. The new model test covers each rename rule.
🤖 Generated with Claude Code