Repository navigation
ci: split internal/goclusterfs across two unit test groups - #180
Merged
Merged
Conversation
internal/goclusterfs alone took 407 s of group 1's 8 min, and #175 adds about 85 s. unit-groups.sh now gives a package with a shard count in unit-timings.txt that many groups of its own, split by test name and balanced with unit-test-timings.txt; the other packages share the rest. CI runs 4 groups: goclusterfs in two halves of about 259 s of test time each, fsck (197 s), and everything else (190 s). make test-unit takes the -run regex from UNIT_RUN in the environment. A split package shows up in two cover profiles, so the coverage summary now merges blocks (covered if either profile ran them) and builds the per-package table from the merged profile instead of go test's lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/goclusterfsalone took 407 s of Unit Tests group 1's 8 min timeout on main 48d1e51; #175 adds ~85 s and hit the timeout at 480 s. A package can't be balanced at package granularity, so it is now split by test name.unit-timings.txt: a third field (shard count) gives a package that many groups to itself.unit-test-timings.txtholds its per-test CI times (from 48d1e51's-vlog) for balancing; unlisted tests count 1 s.unit-groups.sh runprints each group's-runregex;checkalso verifies every test lands in exactly one shard by re-listing with each regex.coverage-summary.shmerges blocks. On main's profiles it reproduces 77.5% and all 28 per-package numbers exactly; on a goclusterfs profile split in two it gives the original 74.4% where plain concatenation gives 37.2%.When a split package grows again, raise its shard count; when timings drift, refresh both files from the
-vlogs.🤖 Generated with Claude Code