Repository navigation
test(history): accept page-cache tears and ESTALE opens under churn, keep the image off tmpfs - #174
Merged
Merged
Conversation
…le twice An open that reaches a removed file gets ESTALE, and the kernel retries it once; under same-name churn the retry can find a removed file too, as on NFS. The checker now records ESTALE from open as its own result, counts it in the summary, and allows it only when the name lost its file at least twice during the call. OPERATIONS.md documents the case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…node A buffered read that overlaps a write on the same node can split at any 8-byte boundary: the kernel copies an up-to-date page to the reader while the write copies into it. Through one GoClusterFS mount, buffered I/O tore inside a 4 KB sector 352 times in 6.4M reads, and O_DIRECT, which bypasses the page cache, never did. The checker now allows such tears at 8-byte boundaries when a write on the reader's node overlapped, and GCFS_IMAGE_DIR lets it keep the image off tmpfs, which tears writes inside a sector by itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ntry from before the open A checker run with the image on ZFS still flagged 8 torn reads and 2 ESTALE opens. Each torn read had one 8-byte word at a boundary whose bytes mixed the values on either side: the kernel's copy can split inside a word. Each ESTALE followed a removal shortly before the open and another during it: the first left the kernel's cached entry stale, the second removed the file the retry found. The checker now ignores such a mixed boundary word, and allows ESTALE on open when the name lost its file during the call and once more within the cache window before it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teaches the history checker the documented outcomes it was flagging, so the remaining violations are real.
GCFS_IMAGE_DIR: keeps the image off tmpfs. tmpfs tears O_DIRECT inside sectors by itself (95k–158k tears in 10 s, against 0 on ext4 or ZFS).History checker, 3 nodes for 3 minutes, 1 GB image:
The ZFS violation is the known cross-node 4 KB tear: a read on one node during a write on another. It stays a violation; the planned cluster read lock fixes it. The tmpfs one comes from tmpfs tearing device writes.
🤖 Generated with Claude Code