Repository navigation
fix(test): wait for the remount in Docker crash-recovery tests - #17
Merged
Merged
Conversation
Journal Crash Recovery Multiple Ops slept 4s after docker start, then called start_goclusterfs, which does not exist, and read file1.txt from the still-unmounted mount point. Both CI failures (main run 40105056198, PR run 40116360883) log "start_goclusterfs: command not found" and "cat: /mnt/goclusterfs/file1.txt: No such file or directory". Network Partition then wrote through node1 before it was mounted. Container restarts take 5-10s on CI. The tests now wait for the node to be healthy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's Docker job fails intermittently (runs 40105056198, 40118141586) in "Journal Crash Recovery Multiple Ops", and "Network Partition" then fails as a knock-on.
After
docker start, the test slept about 4s, calledstart_goclusterfs(which doesn't exist), and readfile1.txt. Node restarts on CI take 5-10s to become healthy, so the read hit the unmounted mount point. The logs showstart_goclusterfs: command not foundfollowed bycat: /mnt/goclusterfs/file1.txt: No such file or directory. Network Partition then wrote through node1 before its mount was up.This PR makes both tests that used
start_goclusterfs(Multiple Ops and Crash During Write) callwait_node_healthyinstead. Split out of #15, where it passed Docker on .66 (34 passed, 0 failed).🤖 Generated with Claude Code