Repository navigation
feat(broadcast): report mounted nodes this node hears no broadcasts from - #166
Merged
Merged
Conversation
A network that drops multicast was invisible: a node that hears nothing from a peer finds no gap in its sequence numbers, so #96's loss check never fires, and only directory lookups lagging by -cache-ttl showed it. Every -broadcast-heartbeat interval (30s by default, now a flag), the broadcaster compares the nodes the registry shows mounted with the ones it has heard. A node silent for 3 intervals since it mounted, or since this node started, gets a WARN naming it, a degraded broadcast-peers check on /health, and a count in goclusterfs_broadcast_silent_peers. Hearing it again logs that and clears it. The Docker nodes run with a 2s heartbeat, so the new Docker test sees node 2 report its three peers within seconds of dropping multicast and recover after the fault is healed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d it The grace period used the peer's MountTime from the registry, written by the peer's clock, against this node's clock, so a peer with a clock ahead went unreported for up to the skew. Silence now counts from when this node first saw the peer in the registry, by its own clock, as #151 did for liveness. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #147: a network that drops multicast is now visible.
How it works:
-broadcast-heartbeatinterval (default 30s, now a flag), the broadcaster compares the nodes the registry shows mounted with the senders it has heard.broadcast-peerscheck on/health, which is new and separate from thebroadcastcheck because the consequence runs the other way (this node sees that peer's changes late);goclusterfs_broadcast_silent_peers.Tests on .68:
TestBroadcastReportsSilentPeer, next to a-broadcast=falsenode: 3/3, reported 1.2–1.7s after that node mounted.-shortsuite, unit tests with-race, lint and parity: all pass.A node mounted with
-broadcast=falseis reported too. That's deliberate: its peers see its changes late as well.🤖 Generated with Claude Code