Skip to content

revert: zero every new block again (reverts #160) - #162

Merged
mattmattox merged 1 commit into
mainfrom
revert/narrow-zeroing-160
Nov 16, 2026
Merged

mattmattox merged 1 commit into
mainfrom
revert/narrow-zeroing-160

Conversation

@mattmattox

Copy link
Copy Markdown
Contributor

Reverts #160 (daa33a6) while its data-corruption cause is found.

Why: the 48h soak on main daa33a6 failed after 5 minutes and 1,311 operations, with no fault injected. A read of /soak/d2/l1-f6 on node 1 returned the right size and wrong content, and the shared disk itself is wrong. Bytes [0, 176128) of that file's block 1 (physical block 61) are zeros, although operation 853 had written data there. That range is exactly the head zero of operation 1098, which ran just before on node 3: a write into a hole of a different file (/l2-c45) at block offset 172325. That write's own new block (physical 60) got its data and zeros correctly. Physical 61 got only the head zero. This is one file's data destroyed by another file's write. Details are in soak-failure-2-zeroed-block-head.md (vm-harness notes).

Evidence for reverting #160 specifically: the same soak driver ran clean on d7f5420 (#145's full-block zeroing, 26,792 ops) and on d85bbe0 (13,609 ops). The commits since are #159, #155 and #160, and #160 is the only one that changes zeroing. The cause isn't proven yet, so the soak reruns on this revert to confirm.

Cost: new data is written twice again (about 2×), as with #145. Correctness first. #160's narrower rule comes back once the cause is found and covered by a test.

This removes #160's own stale-bytes tests. #145's stale-bytes and cross-file pattern tests stay and still pass with the full-block zeroing.

🤖 Generated with Claude Code

The 48h soak on daa33a6 found another file's block with its first
176128 bytes zeroed on disk after a write into a hole on a different
node. That range matches the head zero of the hole write, which points
at #160's narrower zeroing. #145's full-block zeroing ran clean for
26,792 soak ops. Restore it until #160's cause is found.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mattmattox
mattmattox merged commit d2ba9e1 into main Nov 16, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant