Repository navigation
test: ignore the checksum in the snapshot descriptor round trip - #146
Merged
Merged
Conversation
Since #140, bytes 26-27 and 32-35 hold the birth generation only with FlagHasTargetBirth. Without the flag, decoding ignores them and re-encoding writes zeros, so the checksum changes while every field stays the same. FuzzDecodeDescriptor compared the stored checksum too and failed on such descriptors; it now compares the fields. The input that found it is kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks #144: its nightly fuzz run fails FuzzDecodeDescriptor on main.
This is a false positive, not a snapshot bug. Since #140, bytes 26-27 and 32-35 of a descriptor hold the birth generation only when FlagHasTargetBirth is set. Without the flag, decoding ignores them and re-encoding writes zeros there, so the stored checksum changes while every decoded field stays the same. The round-trip check compared the checksum too; it now compares the fields. The input that found it is kept as a regression seed.
Tested on .68:
-raceon internal/snapshot, 60 s of fuzzing, golangci-lint.🤖 Generated with Claude Code