Repository navigation
feat(metrics): report lock acquires, blocked acquires and wait time per lock type - #130
Merged
Merged
Conversation
…er lock type /metrics had only held and pending lock gauges, so contention on the bitmap or refcount lock could not be measured. The per-try counter that LogStats printed as "blocked" is now "retries". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 1 of the per-node block reserve work. The contention probe could only read lock waits from debug log lines, which #97 has since turned off by default, and /metrics had just held and pending gauges. This adds
goclusterfs_lock_acquires_total,goclusterfs_lock_blocked_totalandgoclusterfs_lock_wait_seconds_total, labeled by lock type, and the same figures undertypesin/api/v1/stats/lock. The before and after probes for reserves will read these."Blocked" counts acquires whose first try found the lock taken, once per acquire. The old per-try counter in LogStats is renamed to "retries" so the two aren't confused.
🤖 Generated with Claude Code