Skip to content

feat(metrics): report lock acquires, blocked acquires and wait time per lock type - #130

Merged
mattmattox merged 1 commit into
mainfrom
feat/lock-wait-metrics
Nov 14, 2026
Merged

mattmattox merged 1 commit into
mainfrom
feat/lock-wait-metrics

Conversation

@mattmattox

Copy link
Copy Markdown
Contributor

PR 1 of the per-node block reserve work. The contention probe could only read lock waits from debug log lines, which #97 has since turned off by default, and /metrics had just held and pending gauges. This adds goclusterfs_lock_acquires_total, goclusterfs_lock_blocked_total and goclusterfs_lock_wait_seconds_total, labeled by lock type, and the same figures under types in /api/v1/stats/lock. The before and after probes for reserves will read these.

"Blocked" counts acquires whose first try found the lock taken, once per acquire. The old per-try counter in LogStats is renamed to "retries" so the two aren't confused.

🤖 Generated with Claude Code

…er lock type

/metrics had only held and pending lock gauges, so contention on the
bitmap or refcount lock could not be measured. The per-try counter that
LogStats printed as "blocked" is now "retries".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mattmattox
mattmattox merged commit 48da67d into main Nov 14, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant