Repository navigation
fix(goclusterfs): log failed lock releases and rollback frees; enforce errcheck in the package - #125
Merged
Merged
Conversation
…e errcheck in fs.go Lock releases go through FS.release, which logs ErrNotLockOwner as [ERROR] and other failures as [WARN]. Rollback frees of blocks and new inodes log a failure instead of dropping it, as does the Setattr intent close before a retry and the block free after an unlink. Only the package's tests stay excluded from errcheck. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… the whole package Operations a test crashes on purpose, and device closes that simulate a crash, discard their results. Lock releases in test helpers report a failure. writeImageRange returns its close error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sterfs # Conflicts: # .golangci.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the errcheck rollout; deletes the internal/goclusterfs rule. 21 findings in fs.go, 43 in its tests.
fs.go (data path):
FS.release:ErrNotLockOwnerlogs[ERROR](double release or lock bookkeeping bug), other failures[WARN]. Previously several were dropped or-debugonly. A failed release leaves this node's claim on disk, so other nodes wait on it._ = bitmapMgr.Freein the SFB migration.Tests: operations a test crashes on purpose, and device closes that simulate a crash, discard results; helper lock releases report failures.
A -race run of the package on .68 before the main merge logged no new release/free warnings. Conflicts in
.golangci.ymlwith #124 (neighboring rule).🤖 Generated with Claude Code