Repository navigation
fix(gfsctl): check ignored errors; enforce errcheck except terminal prints - #121
Merged
Merged
Conversation
…rints Test setup now panics if it cannot set the environment or reset a flag, so a test never runs with leftover state. gfsctl keeps ignoring fmt.Fprint* write errors on the terminal, like fmt.Printf does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the errcheck rollout. gfsctl's rule now hides only
fmt.Fprint*findings (27, all terminal output, ignored the same wayfmt.Printfignores them); every other errcheck finding in cmd/gfsctl is fixed and now enforced.No write, sync or lock path here. Test setup (TestMain env, resetFlags) now panics on failure instead of running tests with leftover state.
Remaining errcheck rules: internal/cache, internal/goclusterfs, cmd/mount, tests/benchmark, tests/integration (tests PR next).
🤖 Generated with Claude Code