Skip to content

fix(gfsctl): check ignored errors; enforce errcheck except terminal prints - #121

Merged
mattmattox merged 2 commits into
mainfrom
claude/errcheck-gfsctl
Nov 13, 2026
Merged

mattmattox merged 2 commits into
mainfrom
claude/errcheck-gfsctl

Conversation

@mattmattox

Copy link
Copy Markdown
Contributor

Part of the errcheck rollout. gfsctl's rule now hides only fmt.Fprint* findings (27, all terminal output, ignored the same way fmt.Printf ignores them); every other errcheck finding in cmd/gfsctl is fixed and now enforced.

No write, sync or lock path here. Test setup (TestMain env, resetFlags) now panics on failure instead of running tests with leftover state.

Remaining errcheck rules: internal/cache, internal/goclusterfs, cmd/mount, tests/benchmark, tests/integration (tests PR next).

🤖 Generated with Claude Code

mattmattox and others added 2 commits November 13, 2026 16:00
…rints

Test setup now panics if it cannot set the environment or reset a flag,
so a test never runs with leftover state. gfsctl keeps ignoring
fmt.Fprint* write errors on the terminal, like fmt.Printf does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mattmattox
mattmattox merged commit 16fdd89 into main Nov 13, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant